You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Stan Zapryanov (Created) (JIRA)" <de...@myfaces.apache.org> on 2012/03/07 16:20:59 UTC
[jira] [Created] (TOMAHAWK-1612) Children of h:form within
t:panelGroup still get rendered even though their parent (h:form) has
rendered=false
Children of h:form within t:panelGroup still get rendered even though their parent (h:form) has rendered=false
--------------------------------------------------------------------------------------------------------------
Key: TOMAHAWK-1612
URL: https://issues.apache.org/jira/browse/TOMAHAWK-1612
Project: MyFaces Tomahawk
Issue Type: Bug
Components: Html Tag
Affects Versions: 1.1.11
Environment: Tomahawk20-1.1.11 and MyFaces 2.1.6 (Tomcat7, Java6)
Reporter: Stan Zapryanov
Children of h:form with rendered="false" do get rendered (but should not) IF h:form is placed within t:panelGroup
If t:panelGroup in the example below is changed to h:panelGroup, then everything works correctly (h:form children don't get rendered).
Example demonstrating the bug:
<t:panelGrid>
<t:panelGroup>
<h:form id="testForm" rendered="false">
Stuff inside form should not show but this line shows
</h:form>
</t:panelGroup>
</t:panelGrid>
I did some debugging and it seems to me that the bug is coming from the following change made from Tomahawk20-1.1.10 to Tomahawk20-1.1.11
In class: org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils
Method: public static void renderChild(FacesContext facesContext, UIComponent child) throws IOException
The following lines were removed:
530 if (!child.isRendered())
531 {
532 return;
533 }
There might be other places where this change could be causing problems/bugs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TOMAHAWK-1612) Children of h:form within
t:panelGroup still get rendered even though their parent (h:form) has
rendered=false
Posted by "Leonardo Uribe (Resolved) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe resolved TOMAHAWK-1612.
--------------------------------------
Resolution: Fixed
Fix Version/s: 1.1.12-SNAPSHOT
Assignee: Leonardo Uribe
Fixed in update to latest shared version
> Children of h:form within t:panelGroup still get rendered even though their parent (h:form) has rendered=false
> --------------------------------------------------------------------------------------------------------------
>
> Key: TOMAHAWK-1612
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1612
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Html Tag
> Affects Versions: 1.1.11
> Environment: Tomahawk20-1.1.11 and MyFaces 2.1.6 (Tomcat7, Java6)
> Reporter: Stan Zapryanov
> Assignee: Leonardo Uribe
> Fix For: 1.1.12-SNAPSHOT
>
>
> Children of h:form with rendered="false" do get rendered (but should not) IF h:form is placed within t:panelGroup
> If t:panelGroup in the example below is changed to h:panelGroup, then everything works correctly (h:form children don't get rendered).
> Example demonstrating the bug:
> <t:panelGrid>
> <t:panelGroup>
> <h:form id="testForm" rendered="false">
> Stuff inside form should not show but this line shows
> </h:form>
> </t:panelGroup>
> </t:panelGrid>
> I did some debugging and it seems to me that the bug is coming from the following change made from Tomahawk20-1.1.10 to Tomahawk20-1.1.11
> In class: org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils
> Method: public static void renderChild(FacesContext facesContext, UIComponent child) throws IOException
> The following lines were removed:
> 530 if (!child.isRendered())
> 531 {
> 532 return;
> 533 }
> There might be other places where this change could be causing problems/bugs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira