You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@linkis.apache.org by GitBox <gi...@apache.org> on 2021/10/24 15:44:45 UTC
[GitHub] [incubator-linkis] wForget opened a new pull request #1048: Adjust some unnecessary parameters in the upload interface
wForget opened a new pull request #1048:
URL: https://github.com/apache/incubator-linkis/pull/1048
### What is the purpose of the change
Adjust some unnecessary parameters in the upload interface. see #1047 for details.
### Brief change log
Add the `required = false` configuration for unnecessary parameters.
### Verifying this change
I have verified this change.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no) `no`
- Anything that affects deployment: (yes / no / don't know) `no`
- The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (yes / no) `no`
### Documentation
- Does this pull request introduce a new feature? (yes / no) `no`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone removed a comment on pull request #1048: Adjust some unnecessary parameters in the BML APIs
Posted by GitBox <gi...@apache.org>.
casionone removed a comment on pull request #1048:
URL: https://github.com/apache/incubator-linkis/pull/1048#issuecomment-953462508
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on pull request #1048: Adjust some unnecessary parameters in the upload interface
Posted by GitBox <gi...@apache.org>.
casionone commented on pull request #1048:
URL: https://github.com/apache/incubator-linkis/pull/1048#issuecomment-950464608
The api of "bml/uploadShareResource" has the same problem, you can fix it together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] leeebai removed a comment on pull request #1048: Adjust some unnecessary parameters in the BML APIs
Posted by GitBox <gi...@apache.org>.
leeebai removed a comment on pull request #1048:
URL: https://github.com/apache/incubator-linkis/pull/1048#issuecomment-955992288
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] wForget commented on pull request #1048: Adjust some unnecessary parameters in the BML APIs
Posted by GitBox <gi...@apache.org>.
wForget commented on pull request #1048:
URL: https://github.com/apache/incubator-linkis/pull/1048#issuecomment-953457646
Hi @peacewong , would you help me review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] wForget commented on pull request #1048: Adjust some unnecessary parameters in the upload interface
Posted by GitBox <gi...@apache.org>.
wForget commented on pull request #1048:
URL: https://github.com/apache/incubator-linkis/pull/1048#issuecomment-950528461
> The api of "bml/uploadShareResource" has the same problem, you can fix it together
OK, i will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] leeebai commented on pull request #1048: Adjust some unnecessary parameters in the BML APIs
Posted by GitBox <gi...@apache.org>.
leeebai commented on pull request #1048:
URL: https://github.com/apache/incubator-linkis/pull/1048#issuecomment-955992288
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong merged pull request #1048: Adjust some unnecessary parameters in the BML APIs
Posted by GitBox <gi...@apache.org>.
peacewong merged pull request #1048:
URL: https://github.com/apache/incubator-linkis/pull/1048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on pull request #1048: Adjust some unnecessary parameters in the BML APIs
Posted by GitBox <gi...@apache.org>.
casionone commented on pull request #1048:
URL: https://github.com/apache/incubator-linkis/pull/1048#issuecomment-953462508
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org