You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/01/31 16:39:00 UTC
[GitHub] [ignite] nizhikov opened a new pull request #8732: IGNITE-14071: Test for messaging type auto resolve.
nizhikov opened a new pull request #8732:
URL: https://github.com/apache/ignite/pull/8732
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on pull request #8732: IGNITE-14071: Test for messaging type auto resolve.
Posted by GitBox <gi...@apache.org>.
nizhikov commented on pull request #8732:
URL: https://github.com/apache/ignite/pull/8732#issuecomment-771075268
Hello, @ptupitsyn
Can you, please, take a look at my changes.
This patch enabled "register same java type" mode for messaging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a change in pull request #8732: IGNITE-14071: Test for messaging type auto resolve.
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on a change in pull request #8732:
URL: https://github.com/apache/ignite/pull/8732#discussion_r568098731
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Impl/Messaging/Messaging.cs
##########
@@ -87,35 +87,68 @@ public IClusterGroup ClusterGroup
public void Send(object message, object topic = null)
{
IgniteArgumentCheck.NotNull(message, "message");
+
+ bool locRegisterSameJavaType = Marshaller.RegisterSameJavaTypeTl.Value;
- DoOutOp((int) Op.Send, topic, message);
+ Marshaller.RegisterSameJavaTypeTl.Value = true;
+
+ try
+ {
+ DoOutOp((int) Op.Send, topic, message);
+ }
+ finally
+ {
+ Marshaller.RegisterSameJavaTypeTl.Value = locRegisterSameJavaType;
+ }
}
/** <inheritdoc /> */
public void SendAll(IEnumerable messages, object topic = null)
{
IgniteArgumentCheck.NotNull(messages, "messages");
- DoOutOp((int) Op.SendMulti, writer =>
+ bool locRegisterSameJavaType = Marshaller.RegisterSameJavaTypeTl.Value;
+
+ Marshaller.RegisterSameJavaTypeTl.Value = true;
Review comment:
As [discussed on the dev list](http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSSION-Net-BinaryTypes-transparency-td50998.html), this Java type registration behavior can be only enabled when we are calling Java user code. For `Compute` and `Services` this can be determined precisely. But for `Messaging` we don't know whether listeners are in .NET or Java, so this is a compatibility risk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov closed pull request #8732: IGNITE-14071: Test for messaging type auto resolve.
Posted by GitBox <gi...@apache.org>.
nizhikov closed pull request #8732:
URL: https://github.com/apache/ignite/pull/8732
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org