You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@geode.apache.org by "Anthony Baker (JIRA)" <ji...@apache.org> on 2017/06/17 18:04:14 UTC

[jira] [Closed] (GEODE-2684) org.apache.geode.internal.tcp.Connection & ConnectionTable cleanup

     [ https://issues.apache.org/jira/browse/GEODE-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anthony Baker closed GEODE-2684.
--------------------------------

> org.apache.geode.internal.tcp.Connection & ConnectionTable cleanup
> ------------------------------------------------------------------
>
>                 Key: GEODE-2684
>                 URL: https://issues.apache.org/jira/browse/GEODE-2684
>             Project: Geode
>          Issue Type: Task
>          Components: membership
>            Reporter: Bruce Schuchardt
>             Fix For: 1.2.0
>
>
> These classes contain a lot of commented-out code, poorly named methods and incorrect calculations that need to be cleaned up.  For instance, Connection contains this:
> short aShort = -1;
> bytes[x] = (byte)(aShort & 0xff / 0x100);
> bytes[x+1] = (byte)(aShort & 0xff);
> which is incorrect and results in bytes[x] being zero when the intent is for it to be 255.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)