Re: [PR] API, Core: Add scan planning api request and response models [iceberg]

["rahil-c (via GitHub)" <gi...@apache.org>]

rahil-c commented on PR #11180:
URL: https://github.com/apache/iceberg/pull/11180#issuecomment-2403620243

   @rdblue @danielcweeks @amogh-jahagirdar @jackye1995 @singhpk234  When implementing the parsers, one thing that I noticed was that not having a `partition-spec` sent back from the service during the time of several response serialization/deserialization causes several issues from client implementation standpoint. 
   
   I have marked these areas with `TODO` comments so its easier for reviewers to see the complexities behind this and would recommend that we have a discussion around the pros/cons of the service sending back a `parition-spec` in the `FileScanTask` model.
   
    The `spec-id` from the `DataFile` alone is not enough to find the correct the partition-spec because we do not have the `TableMetadata` at the time of serialization/deserialization to obtain the relevant partition spec. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org