You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by se...@apache.org on 2020/10/01 23:16:37 UTC

[whimsy] branch master updated: Try to fix Travis failures

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 315cdc2  Try to fix Travis failures
315cdc2 is described below

commit 315cdc29eea87a6016b440108a308037667d17ae
Author: Sebb <se...@apache.org>
AuthorDate: Fri Oct 2 00:16:27 2020 +0100

    Try to fix Travis failures
    
    Revert to 3.2.0 as was used until Sep 30
---
 www/board/agenda/Gemfile        | 2 +-
 www/roster/Gemfile              | 2 +-
 www/secretary/Gemfile           | 2 +-
 www/secretary/workbench/Gemfile | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/www/board/agenda/Gemfile b/www/board/agenda/Gemfile
index 2e79924..f838780 100644
--- a/www/board/agenda/Gemfile
+++ b/www/board/agenda/Gemfile
@@ -14,7 +14,7 @@ end
 gem 'rake'
 wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
 gem 'wunderbar', wunderbar_version
-gem 'ruby2js', '>= 3.3.1' # Travis fails with 3.3.0
+gem 'ruby2js', '3.2.0' # Travis fails with 3.3.[01]
 gem 'sinatra', '~> 2.0'
 gem 'nokogumbo'
 gem 'execjs'
diff --git a/www/roster/Gemfile b/www/roster/Gemfile
index e959e1c..b95b313 100644
--- a/www/roster/Gemfile
+++ b/www/roster/Gemfile
@@ -15,7 +15,7 @@ end
 gem 'rake'
 wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
 gem 'wunderbar', wunderbar_version
-gem 'ruby2js', '>= 3.3.1' # Travis fails with 3.3.0
+gem 'ruby2js', '3.2.0' # Travis fails with 3.3.[01]
 gem 'sinatra', '~> 2.0'
 gem 'nokogumbo'
 gem 'mail'
diff --git a/www/secretary/Gemfile b/www/secretary/Gemfile
index 5b0423e..02a77e0 100644
--- a/www/secretary/Gemfile
+++ b/www/secretary/Gemfile
@@ -8,7 +8,7 @@ if File.exist? version_file
   gem 'whimsy-asf', asf_version, path: File.expand_path(root, __FILE__)
 end
 
-gem 'ruby2js', '>= 3.3.1' # Travis fails with 3.3.0
+gem 'ruby2js', '3.2.0' # Travis fails with 3.3.[01]
 wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
 gem 'wunderbar', wunderbar_version
 gem 'mail'
diff --git a/www/secretary/workbench/Gemfile b/www/secretary/workbench/Gemfile
index 4c68f8a..5e01e30 100644
--- a/www/secretary/workbench/Gemfile
+++ b/www/secretary/workbench/Gemfile
@@ -18,7 +18,7 @@ gem 'sinatra', '~> 2.0'
 gem 'sanitize'
 wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
 gem 'wunderbar', wunderbar_version
-gem 'ruby2js', '>= 3.3.1' # Travis fails with 3.3.0
+gem 'ruby2js', '3.2.0' # Travis fails with 3.3.[01]
 gem 'execjs'
 gem 'listen'
 gem 'escape'


Re: [whimsy] branch master updated: Try to fix Travis failures

Posted by sebb <se...@gmail.com>.
Do we need to test anything other than 2.7?

On Fri, 2 Oct 2020 at 01:15, Sam Ruby <ru...@intertwingly.net> wrote:
>
> It might also be a good idea to revisit the ruby version(s) tested
> with Travis...
>
> - Sam Ruby
>
> On Thu, Oct 1, 2020 at 7:46 PM sebb <se...@gmail.com> wrote:
> >
> > Ah, I have:
> >
> > $ node -v
> > v14.8.0
> >
> > which probably explains why I was not seeing any errors.
> >
> > On Fri, 2 Oct 2020 at 00:36, Sam Ruby <ru...@intertwingly.net> wrote:
> > >
> > > The following line fails with node 7 but works with node 8+:
> > >
> > > let private_lines = /^([
> > > \t]*&lt;private&gt;(?:\n|.)*?&lt;\/private&gt;)(\s*)$/migs;
> > >
> > > I've fixed .travis.yml.
> > >
> > > - Sam Ruby
> > >
> > > On Thu, Oct 1, 2020 at 7:16 PM <se...@apache.org> wrote:
> > > >
> > > > This is an automated email from the ASF dual-hosted git repository.
> > > >
> > > > sebb pushed a commit to branch master
> > > > in repository https://gitbox.apache.org/repos/asf/whimsy.git
> > > >
> > > >
> > > > The following commit(s) were added to refs/heads/master by this push:
> > > >      new 315cdc2  Try to fix Travis failures
> > > > 315cdc2 is described below
> > > >
> > > > commit 315cdc29eea87a6016b440108a308037667d17ae
> > > > Author: Sebb <se...@apache.org>
> > > > AuthorDate: Fri Oct 2 00:16:27 2020 +0100
> > > >
> > > >     Try to fix Travis failures
> > > >
> > > >     Revert to 3.2.0 as was used until Sep 30
> > > > ---
> > > >  www/board/agenda/Gemfile        | 2 +-
> > > >  www/roster/Gemfile              | 2 +-
> > > >  www/secretary/Gemfile           | 2 +-
> > > >  www/secretary/workbench/Gemfile | 2 +-
> > > >  4 files changed, 4 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/www/board/agenda/Gemfile b/www/board/agenda/Gemfile
> > > > index 2e79924..f838780 100644
> > > > --- a/www/board/agenda/Gemfile
> > > > +++ b/www/board/agenda/Gemfile
> > > > @@ -14,7 +14,7 @@ end
> > > >  gem 'rake'
> > > >  wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
> > > >  gem 'wunderbar', wunderbar_version
> > > > -gem 'ruby2js', '>= 3.3.1' # Travis fails with 3.3.0
> > > > +gem 'ruby2js', '3.2.0' # Travis fails with 3.3.[01]
> > > >  gem 'sinatra', '~> 2.0'
> > > >  gem 'nokogumbo'
> > > >  gem 'execjs'
> > > > diff --git a/www/roster/Gemfile b/www/roster/Gemfile
> > > > index e959e1c..b95b313 100644
> > > > --- a/www/roster/Gemfile
> > > > +++ b/www/roster/Gemfile
> > > > @@ -15,7 +15,7 @@ end
> > > >  gem 'rake'
> > > >  wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
> > > >  gem 'wunderbar', wunderbar_version
> > > > -gem 'ruby2js', '>= 3.3.1' # Travis fails with 3.3.0
> > > > +gem 'ruby2js', '3.2.0' # Travis fails with 3.3.[01]
> > > >  gem 'sinatra', '~> 2.0'
> > > >  gem 'nokogumbo'
> > > >  gem 'mail'
> > > > diff --git a/www/secretary/Gemfile b/www/secretary/Gemfile
> > > > index 5b0423e..02a77e0 100644
> > > > --- a/www/secretary/Gemfile
> > > > +++ b/www/secretary/Gemfile
> > > > @@ -8,7 +8,7 @@ if File.exist? version_file
> > > >    gem 'whimsy-asf', asf_version, path: File.expand_path(root, __FILE__)
> > > >  end
> > > >
> > > > -gem 'ruby2js', '>= 3.3.1' # Travis fails with 3.3.0
> > > > +gem 'ruby2js', '3.2.0' # Travis fails with 3.3.[01]
> > > >  wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
> > > >  gem 'wunderbar', wunderbar_version
> > > >  gem 'mail'
> > > > diff --git a/www/secretary/workbench/Gemfile b/www/secretary/workbench/Gemfile
> > > > index 4c68f8a..5e01e30 100644
> > > > --- a/www/secretary/workbench/Gemfile
> > > > +++ b/www/secretary/workbench/Gemfile
> > > > @@ -18,7 +18,7 @@ gem 'sinatra', '~> 2.0'
> > > >  gem 'sanitize'
> > > >  wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
> > > >  gem 'wunderbar', wunderbar_version
> > > > -gem 'ruby2js', '>= 3.3.1' # Travis fails with 3.3.0
> > > > +gem 'ruby2js', '3.2.0' # Travis fails with 3.3.[01]
> > > >  gem 'execjs'
> > > >  gem 'listen'
> > > >  gem 'escape'
> > > >

Re: [whimsy] branch master updated: Try to fix Travis failures

Posted by Sam Ruby <ru...@intertwingly.net>.
It might also be a good idea to revisit the ruby version(s) tested
with Travis...

- Sam Ruby

On Thu, Oct 1, 2020 at 7:46 PM sebb <se...@gmail.com> wrote:
>
> Ah, I have:
>
> $ node -v
> v14.8.0
>
> which probably explains why I was not seeing any errors.
>
> On Fri, 2 Oct 2020 at 00:36, Sam Ruby <ru...@intertwingly.net> wrote:
> >
> > The following line fails with node 7 but works with node 8+:
> >
> > let private_lines = /^([
> > \t]*&lt;private&gt;(?:\n|.)*?&lt;\/private&gt;)(\s*)$/migs;
> >
> > I've fixed .travis.yml.
> >
> > - Sam Ruby
> >
> > On Thu, Oct 1, 2020 at 7:16 PM <se...@apache.org> wrote:
> > >
> > > This is an automated email from the ASF dual-hosted git repository.
> > >
> > > sebb pushed a commit to branch master
> > > in repository https://gitbox.apache.org/repos/asf/whimsy.git
> > >
> > >
> > > The following commit(s) were added to refs/heads/master by this push:
> > >      new 315cdc2  Try to fix Travis failures
> > > 315cdc2 is described below
> > >
> > > commit 315cdc29eea87a6016b440108a308037667d17ae
> > > Author: Sebb <se...@apache.org>
> > > AuthorDate: Fri Oct 2 00:16:27 2020 +0100
> > >
> > >     Try to fix Travis failures
> > >
> > >     Revert to 3.2.0 as was used until Sep 30
> > > ---
> > >  www/board/agenda/Gemfile        | 2 +-
> > >  www/roster/Gemfile              | 2 +-
> > >  www/secretary/Gemfile           | 2 +-
> > >  www/secretary/workbench/Gemfile | 2 +-
> > >  4 files changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/www/board/agenda/Gemfile b/www/board/agenda/Gemfile
> > > index 2e79924..f838780 100644
> > > --- a/www/board/agenda/Gemfile
> > > +++ b/www/board/agenda/Gemfile
> > > @@ -14,7 +14,7 @@ end
> > >  gem 'rake'
> > >  wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
> > >  gem 'wunderbar', wunderbar_version
> > > -gem 'ruby2js', '>= 3.3.1' # Travis fails with 3.3.0
> > > +gem 'ruby2js', '3.2.0' # Travis fails with 3.3.[01]
> > >  gem 'sinatra', '~> 2.0'
> > >  gem 'nokogumbo'
> > >  gem 'execjs'
> > > diff --git a/www/roster/Gemfile b/www/roster/Gemfile
> > > index e959e1c..b95b313 100644
> > > --- a/www/roster/Gemfile
> > > +++ b/www/roster/Gemfile
> > > @@ -15,7 +15,7 @@ end
> > >  gem 'rake'
> > >  wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
> > >  gem 'wunderbar', wunderbar_version
> > > -gem 'ruby2js', '>= 3.3.1' # Travis fails with 3.3.0
> > > +gem 'ruby2js', '3.2.0' # Travis fails with 3.3.[01]
> > >  gem 'sinatra', '~> 2.0'
> > >  gem 'nokogumbo'
> > >  gem 'mail'
> > > diff --git a/www/secretary/Gemfile b/www/secretary/Gemfile
> > > index 5b0423e..02a77e0 100644
> > > --- a/www/secretary/Gemfile
> > > +++ b/www/secretary/Gemfile
> > > @@ -8,7 +8,7 @@ if File.exist? version_file
> > >    gem 'whimsy-asf', asf_version, path: File.expand_path(root, __FILE__)
> > >  end
> > >
> > > -gem 'ruby2js', '>= 3.3.1' # Travis fails with 3.3.0
> > > +gem 'ruby2js', '3.2.0' # Travis fails with 3.3.[01]
> > >  wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
> > >  gem 'wunderbar', wunderbar_version
> > >  gem 'mail'
> > > diff --git a/www/secretary/workbench/Gemfile b/www/secretary/workbench/Gemfile
> > > index 4c68f8a..5e01e30 100644
> > > --- a/www/secretary/workbench/Gemfile
> > > +++ b/www/secretary/workbench/Gemfile
> > > @@ -18,7 +18,7 @@ gem 'sinatra', '~> 2.0'
> > >  gem 'sanitize'
> > >  wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
> > >  gem 'wunderbar', wunderbar_version
> > > -gem 'ruby2js', '>= 3.3.1' # Travis fails with 3.3.0
> > > +gem 'ruby2js', '3.2.0' # Travis fails with 3.3.[01]
> > >  gem 'execjs'
> > >  gem 'listen'
> > >  gem 'escape'
> > >

Re: [whimsy] branch master updated: Try to fix Travis failures

Posted by sebb <se...@gmail.com>.
Ah, I have:

$ node -v
v14.8.0

which probably explains why I was not seeing any errors.

On Fri, 2 Oct 2020 at 00:36, Sam Ruby <ru...@intertwingly.net> wrote:
>
> The following line fails with node 7 but works with node 8+:
>
> let private_lines = /^([
> \t]*&lt;private&gt;(?:\n|.)*?&lt;\/private&gt;)(\s*)$/migs;
>
> I've fixed .travis.yml.
>
> - Sam Ruby
>
> On Thu, Oct 1, 2020 at 7:16 PM <se...@apache.org> wrote:
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > sebb pushed a commit to branch master
> > in repository https://gitbox.apache.org/repos/asf/whimsy.git
> >
> >
> > The following commit(s) were added to refs/heads/master by this push:
> >      new 315cdc2  Try to fix Travis failures
> > 315cdc2 is described below
> >
> > commit 315cdc29eea87a6016b440108a308037667d17ae
> > Author: Sebb <se...@apache.org>
> > AuthorDate: Fri Oct 2 00:16:27 2020 +0100
> >
> >     Try to fix Travis failures
> >
> >     Revert to 3.2.0 as was used until Sep 30
> > ---
> >  www/board/agenda/Gemfile        | 2 +-
> >  www/roster/Gemfile              | 2 +-
> >  www/secretary/Gemfile           | 2 +-
> >  www/secretary/workbench/Gemfile | 2 +-
> >  4 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/www/board/agenda/Gemfile b/www/board/agenda/Gemfile
> > index 2e79924..f838780 100644
> > --- a/www/board/agenda/Gemfile
> > +++ b/www/board/agenda/Gemfile
> > @@ -14,7 +14,7 @@ end
> >  gem 'rake'
> >  wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
> >  gem 'wunderbar', wunderbar_version
> > -gem 'ruby2js', '>= 3.3.1' # Travis fails with 3.3.0
> > +gem 'ruby2js', '3.2.0' # Travis fails with 3.3.[01]
> >  gem 'sinatra', '~> 2.0'
> >  gem 'nokogumbo'
> >  gem 'execjs'
> > diff --git a/www/roster/Gemfile b/www/roster/Gemfile
> > index e959e1c..b95b313 100644
> > --- a/www/roster/Gemfile
> > +++ b/www/roster/Gemfile
> > @@ -15,7 +15,7 @@ end
> >  gem 'rake'
> >  wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
> >  gem 'wunderbar', wunderbar_version
> > -gem 'ruby2js', '>= 3.3.1' # Travis fails with 3.3.0
> > +gem 'ruby2js', '3.2.0' # Travis fails with 3.3.[01]
> >  gem 'sinatra', '~> 2.0'
> >  gem 'nokogumbo'
> >  gem 'mail'
> > diff --git a/www/secretary/Gemfile b/www/secretary/Gemfile
> > index 5b0423e..02a77e0 100644
> > --- a/www/secretary/Gemfile
> > +++ b/www/secretary/Gemfile
> > @@ -8,7 +8,7 @@ if File.exist? version_file
> >    gem 'whimsy-asf', asf_version, path: File.expand_path(root, __FILE__)
> >  end
> >
> > -gem 'ruby2js', '>= 3.3.1' # Travis fails with 3.3.0
> > +gem 'ruby2js', '3.2.0' # Travis fails with 3.3.[01]
> >  wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
> >  gem 'wunderbar', wunderbar_version
> >  gem 'mail'
> > diff --git a/www/secretary/workbench/Gemfile b/www/secretary/workbench/Gemfile
> > index 4c68f8a..5e01e30 100644
> > --- a/www/secretary/workbench/Gemfile
> > +++ b/www/secretary/workbench/Gemfile
> > @@ -18,7 +18,7 @@ gem 'sinatra', '~> 2.0'
> >  gem 'sanitize'
> >  wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
> >  gem 'wunderbar', wunderbar_version
> > -gem 'ruby2js', '>= 3.3.1' # Travis fails with 3.3.0
> > +gem 'ruby2js', '3.2.0' # Travis fails with 3.3.[01]
> >  gem 'execjs'
> >  gem 'listen'
> >  gem 'escape'
> >

Re: [whimsy] branch master updated: Try to fix Travis failures

Posted by Sam Ruby <ru...@intertwingly.net>.
The following line fails with node 7 but works with node 8+:

let private_lines = /^([
\t]*&lt;private&gt;(?:\n|.)*?&lt;\/private&gt;)(\s*)$/migs;

I've fixed .travis.yml.

- Sam Ruby

On Thu, Oct 1, 2020 at 7:16 PM <se...@apache.org> wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> sebb pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/whimsy.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
>      new 315cdc2  Try to fix Travis failures
> 315cdc2 is described below
>
> commit 315cdc29eea87a6016b440108a308037667d17ae
> Author: Sebb <se...@apache.org>
> AuthorDate: Fri Oct 2 00:16:27 2020 +0100
>
>     Try to fix Travis failures
>
>     Revert to 3.2.0 as was used until Sep 30
> ---
>  www/board/agenda/Gemfile        | 2 +-
>  www/roster/Gemfile              | 2 +-
>  www/secretary/Gemfile           | 2 +-
>  www/secretary/workbench/Gemfile | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/www/board/agenda/Gemfile b/www/board/agenda/Gemfile
> index 2e79924..f838780 100644
> --- a/www/board/agenda/Gemfile
> +++ b/www/board/agenda/Gemfile
> @@ -14,7 +14,7 @@ end
>  gem 'rake'
>  wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
>  gem 'wunderbar', wunderbar_version
> -gem 'ruby2js', '>= 3.3.1' # Travis fails with 3.3.0
> +gem 'ruby2js', '3.2.0' # Travis fails with 3.3.[01]
>  gem 'sinatra', '~> 2.0'
>  gem 'nokogumbo'
>  gem 'execjs'
> diff --git a/www/roster/Gemfile b/www/roster/Gemfile
> index e959e1c..b95b313 100644
> --- a/www/roster/Gemfile
> +++ b/www/roster/Gemfile
> @@ -15,7 +15,7 @@ end
>  gem 'rake'
>  wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
>  gem 'wunderbar', wunderbar_version
> -gem 'ruby2js', '>= 3.3.1' # Travis fails with 3.3.0
> +gem 'ruby2js', '3.2.0' # Travis fails with 3.3.[01]
>  gem 'sinatra', '~> 2.0'
>  gem 'nokogumbo'
>  gem 'mail'
> diff --git a/www/secretary/Gemfile b/www/secretary/Gemfile
> index 5b0423e..02a77e0 100644
> --- a/www/secretary/Gemfile
> +++ b/www/secretary/Gemfile
> @@ -8,7 +8,7 @@ if File.exist? version_file
>    gem 'whimsy-asf', asf_version, path: File.expand_path(root, __FILE__)
>  end
>
> -gem 'ruby2js', '>= 3.3.1' # Travis fails with 3.3.0
> +gem 'ruby2js', '3.2.0' # Travis fails with 3.3.[01]
>  wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
>  gem 'wunderbar', wunderbar_version
>  gem 'mail'
> diff --git a/www/secretary/workbench/Gemfile b/www/secretary/workbench/Gemfile
> index 4c68f8a..5e01e30 100644
> --- a/www/secretary/workbench/Gemfile
> +++ b/www/secretary/workbench/Gemfile
> @@ -18,7 +18,7 @@ gem 'sinatra', '~> 2.0'
>  gem 'sanitize'
>  wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
>  gem 'wunderbar', wunderbar_version
> -gem 'ruby2js', '>= 3.3.1' # Travis fails with 3.3.0
> +gem 'ruby2js', '3.2.0' # Travis fails with 3.3.[01]
>  gem 'execjs'
>  gem 'listen'
>  gem 'escape'
>