[GitHub] [netbeans] lkishalmi commented on pull request #5379: Fixed erroneous direct form of comparison ("==") for these object typ…

["lkishalmi (via GitHub)" <gi...@apache.org>]

lkishalmi commented on PR #5379:
URL: https://github.com/apache/netbeans/pull/5379#issuecomment-1407584411

   Well, I'm sorry this one is noise.
   
   Many of the changes are touching ancient code written probably for Java 1.4 or earlier. Checking reference equality when the reference is a public constant was usual as these things were treated like enums and maybe for performance reasons,
   
   The `Objects` class is available from Java 7. Replacing those would improve the readability, I see value in that. I'd create a separate PR with those, maybe that would not touch so many files.
   
   Replacing the `==`-s in this one, I fear holds no value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists