You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Daniel Shahaf <da...@apache.org> on 2012/09/02 03:51:46 UTC
[CMS PATCH] s/blacklisting/whitelisting/
Clone URL (Committers only):
https://cms.apache.org/redirect?new=danielsh;action=diff;uri=http://trafficserver.apache.org/
It's good practice to start from an empty environment and add only what is needed, rather than do the opposite. The attach patch implements that. Where did you find code that does the opposite? Was it on any *.a.o site?
Daniel
P.S. Not subscribed; please CC on replies.
Index: trunk/cgi-bin/random.cgi
===================================================================
--- trunk/cgi-bin/random.cgi (revision 1379906)
+++ trunk/cgi-bin/random.cgi (working copy)
@@ -1,6 +1,6 @@
#!/usr/bin/perl -T
+%ENV = ();
$ENV{ 'PATH' } = '/bin:/usr/bin:/usr/local/bin';
-delete @ENV{ 'IFS', 'CDPATH', 'ENV', 'BASH_ENV' };
my $response = `curl 'https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+TS+AND+status+%3D+Open+ORDER+BY+priority+DESC&mode=hide'`;
my @matches = ( $response =~ /browse\/(TS\-\d+)/g );
my $length = $#matches + 1;
Re: [CMS PATCH] s/blacklisting/whitelisting/
Posted by Igor Galić <i....@brainsware.org>.
Thanks, applied!
i
----- Original Message -----
> Clone URL (Committers only):
> https://cms.apache.org/redirect?new=danielsh;action=diff;uri=http://trafficserver.apache.org/
>
> It's good practice to start from an empty environment and add only
> what is needed, rather than do the opposite. The attach patch
> implements that. Where did you find code that does the opposite?
> Was it on any *.a.o site?
>
> Daniel
>
> P.S. Not subscribed; please CC on replies.
>
> Index: trunk/cgi-bin/random.cgi
> ===================================================================
> --- trunk/cgi-bin/random.cgi (revision 1379906)
> +++ trunk/cgi-bin/random.cgi (working copy)
> @@ -1,6 +1,6 @@
> #!/usr/bin/perl -T
> +%ENV = ();
> $ENV{ 'PATH' } = '/bin:/usr/bin:/usr/local/bin';
> -delete @ENV{ 'IFS', 'CDPATH', 'ENV', 'BASH_ENV' };
> my $response = `curl
> 'https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+TS+AND+status+%3D+Open+ORDER+BY+priority+DESC&mode=hide'`;
> my @matches = ( $response =~ /browse\/(TS\-\d+)/g );
> my $length = $#matches + 1;
>
>
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE