You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2019/11/06 17:52:58 UTC

[GitHub] [incubator-tvm] vinx13 commented on a change in pull request #4260: [TOPI] Fix bug in Winograd on CUDA

vinx13 commented on a change in pull request #4260: [TOPI] Fix bug in Winograd on CUDA
URL: https://github.com/apache/incubator-tvm/pull/4260#discussion_r343239743
 
 

 ##########
 File path: topi/python/topi/cuda/conv2d_winograd.py
 ##########
 @@ -42,25 +45,24 @@ def winograd_cuda(cfg, data, kernel, strides, padding, dilation, layout, out_dty
 
     N, CI, H, W = get_const_tuple(data.shape)
 
+    if isinstance(dilation, int):
+        dilation_h = dilation_w = dilation
+    else:
+        dilation_h, dilation_w = dilation
+    HPAD, WPAD, _, _ = nn.get_pad_tuple(padding, kernel)
 
 Review comment:
   does this work when kernel is pre-computed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services