[GitHub] [helix] xyuanlu commented on a change in pull request #1534: Fix several tests with resource leakage

[GitBox <gi...@apache.org>]

xyuanlu commented on a change in pull request #1534:
URL: https://github.com/apache/helix/pull/1534#discussion_r525607202



##########
File path: helix-core/src/test/java/org/apache/helix/controller/changedetector/TestResourceChangeDetector.java
##########
@@ -431,8 +431,12 @@ public void testResetSnapshots() {
             .setResources(new HashSet<>(_dataAccessor.getChildNames(_keyBuilder.idealStates())))
             .setWaitTillVerify(TestHelper.DEFAULT_REBALANCE_PROCESSING_WAIT_TIME)
             .build();
-    Assert.assertTrue(_clusterVerifier.verify());
-
+    try {
+      boolean result = _clusterVerifier.verify();

Review comment:
       nit: Can we do 
   Assert.assertTrue(_clusterVerifier.verify()); ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org