You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/06/24 17:47:47 UTC
[GitHub] [nifi] natural commented on a change in pull request #3542:
NIFI-6363 Integrates AWS KMS SPP. Refactors SSPP.
natural commented on a change in pull request #3542: NIFI-6363 Integrates AWS KMS SPP. Refactors SSPP.
URL: https://github.com/apache/nifi/pull/3542#discussion_r296839885
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-properties-loader/src/main/java/org/apache/nifi/properties/sensitive/ProtectedNiFiProperties.java
##########
@@ -53,17 +57,17 @@
public static final List<String> DEFAULT_SENSITIVE_PROPERTIES = new ArrayList<>(asList(SECURITY_KEY_PASSWD,
SECURITY_KEYSTORE_PASSWD, SECURITY_TRUSTSTORE_PASSWD, SENSITIVE_PROPS_KEY, PROVENANCE_REPO_ENCRYPTION_KEY));
- public ProtectedNiFiProperties() {
- this(new StandardNiFiProperties());
- }
+ // Default encryption key, hex encoded.
+ private String defaultKeyHex;
Review comment:
That's a good idea. I've replaced the string member with an instance of SensitivePropertyProvider.
I've also added constructors to that accept strings and create SSPP instances as a convenience for the caller.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services