[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1951: minor: refine code

[GitBox <gi...@apache.org>]

xudong963 commented on a change in pull request #1951:
URL: https://github.com/apache/arrow-datafusion/pull/1951#discussion_r821439318



##########
File path: datafusion/src/logical_plan/plan.rs
##########
@@ -191,7 +191,7 @@ pub struct DropTable {
     /// The table name
     pub name: String,
     /// If the table exists
-    pub if_exist: bool,
+    pub if_exists: bool,

Review comment:
       Consistent with `Statement::Drop`

##########
File path: datafusion/src/sql/planner.rs
##########
@@ -194,7 +182,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
             {
                 Ok(LogicalPlan::DropTable(DropTable {
                     name: names.get(0).unwrap().to_string(),
-                    if_exist: *if_exists,
+                    if_exists: *if_exists,

Review comment:
       After https://github.com/apache/arrow-datafusion/pull/1945/files merged,  here can directly `if_exists`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org