You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/08/17 22:26:52 UTC
[GitHub] [iceberg] aokolnychyi opened a new pull request #2992: Core: Validate transforms while building partition type
aokolnychyi opened a new pull request #2992:
URL: https://github.com/apache/iceberg/pull/2992
Until we store the output type of transforms, we should fail building the partition type if we hit `UnknownTransform`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2992: Core: Validate transforms while building partition type
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2992:
URL: https://github.com/apache/iceberg/pull/2992#issuecomment-901437744
Thanks for reviewing, @kbendick @yyanyy @jackye1995!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2992: Core: Validate transforms while building partition type
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2992:
URL: https://github.com/apache/iceberg/pull/2992#issuecomment-900743494
cc @RussellSpitzer @szehon-ho @jackye1995 @yyanyy @kbendick @karuppayya @rdblue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2992: Core: Validate transforms while building partition type
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2992:
URL: https://github.com/apache/iceberg/pull/2992#issuecomment-900743494
cc @RussellSpitzer @szehon-ho @jackye1995 @yyanyy @kbendick @karuppayya @rdblue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2992: Core: Validate transforms while building partition type
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2992:
URL: https://github.com/apache/iceberg/pull/2992#issuecomment-901433666
@yyanyy, that's exactly the use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2992: Core: Validate transforms while building partition type
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2992:
URL: https://github.com/apache/iceberg/pull/2992#issuecomment-901423722
@kbendick, this is a follow-up to #2936 where I added `Partitioning#partitionType`. It is only used within these metadata tables that I added tests for. W.r.t. reading the table itself, we have `TestForwardCompatibility` that already covers writing and reading to a table with unknown transforms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi merged pull request #2992: Core: Validate transforms while building partition type
Posted by GitBox <gi...@apache.org>.
aokolnychyi merged pull request #2992:
URL: https://github.com/apache/iceberg/pull/2992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org