You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/08/14 22:26:42 UTC

[GitHub] jbacon commented on issue #3475: [AIRFLOW-2315] Improve S3Hook

jbacon commented on issue #3475: [AIRFLOW-2315] Improve S3Hook
URL: https://github.com/apache/incubator-airflow/pull/3475#issuecomment-413036051
 
 
   Commits will be squashed, linting will be performed, and I'm working on getting these tests to pass.
   
   Regarding Test Failures:
   It seems improper `AwsHook` instantiation is causing most of my headache here. Some code uses `aws_conn_id=None` by default, which breaks my usage of `BaseHook.get_connection(conn_id)` (in order to fetch the json extras). I'm attempting to refactor all instances of `aws_conn_id=None`, changing them to `aws_conn_id="aws_default"`. I don't think this should cause backward compatibility issues. I appreciate any code reviews. Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services