You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Michael Han (JIRA)" <ji...@apache.org> on 2017/03/13 16:22:05 UTC
[jira] [Updated] (ZOOKEEPER-910) Use SelectionKey.isXYZ() methods
instead of complicated binary logic
[ https://issues.apache.org/jira/browse/ZOOKEEPER-910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Han updated ZOOKEEPER-910:
----------------------------------
Fix Version/s: (was: 3.5.3)
3.5.4
> Use SelectionKey.isXYZ() methods instead of complicated binary logic
> --------------------------------------------------------------------
>
> Key: ZOOKEEPER-910
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-910
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Thomas Koch
> Assignee: Michi Mutsuzaki
> Priority: Minor
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-910.patch
>
>
> The SelectionKey class provides methods to replace something like this
> (k.readyOps() & (SelectionKey.OP_READ | SelectionKey.OP_WRITE)) != 0
> with
> selectionKey.isReadable() || selectionKey.isWritable()
> It may be possible, that the first version saves a CPU cycle or two, but the later version saves developer brain cycles which are much more expensive.
> I suppose that there are many more places in the server code where this replacement could be done. I propose that whoever touches a code line like this should make the replacement.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)