You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/07/28 22:15:55 UTC
[GitHub] [yunikorn-core] craigcondit opened a new pull request, #426: [YUNIKORN-1269] Remove obsolete preemption code
craigcondit opened a new pull request, #426:
URL: https://github.com/apache/yunikorn-core/pull/426
### What is this PR for?
Remove obsolete and inactive preemption code. This was committed a few years ago, never activated and has bitrotted significantly. Since we will be working on a new design shortly, removing this code is a useful cleanup.
This PR removes all logic related to preemption, but leaves configuration in place (enable/disable). This will give us a clean basis for the real preemption feature.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [x] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1269
### How should this be tested?
Removal of dead code, so existing tests should pass.
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit closed pull request #426: [YUNIKORN-1269] Remove obsolete preemption code
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #426: [YUNIKORN-1269] Remove obsolete preemption code
URL: https://github.com/apache/yunikorn-core/pull/426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #426: [YUNIKORN-1269] Remove obsolete preemption code
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #426:
URL: https://github.com/apache/yunikorn-core/pull/426#issuecomment-1198686317
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/426?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#426](https://codecov.io/gh/apache/yunikorn-core/pull/426?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bfb6769) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/161c38100317ec239965e21806ebb35c6583ddcd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (161c381) will **increase** coverage by `2.34%`.
> The diff coverage is `33.33%`.
```diff
@@ Coverage Diff @@
## master #426 +/- ##
==========================================
+ Coverage 69.52% 71.87% +2.34%
==========================================
Files 68 65 -3
Lines 10014 9602 -412
==========================================
- Hits 6962 6901 -61
+ Misses 2809 2458 -351
Partials 243 243
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/allocation.go](https://codecov.io/gh/apache/yunikorn-core/pull/426/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FsbG9jYXRpb24uZ28=) | `89.13% <ø> (+0.89%)` | :arrow_up: |
| [pkg/scheduler/objects/allocation\_ask.go](https://codecov.io/gh/apache/yunikorn-core/pull/426/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FsbG9jYXRpb25fYXNrLmdv) | `92.37% <ø> (-0.49%)` | :arrow_down: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/yunikorn-core/pull/426/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `56.51% <0.00%> (-0.08%)` | :arrow_down: |
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/yunikorn-core/pull/426/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `69.90% <ø> (-0.83%)` | :arrow_down: |
| [pkg/scheduler/scheduler.go](https://codecov.io/gh/apache/yunikorn-core/pull/426/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9zY2hlZHVsZXIuZ28=) | `0.00% <ø> (ø)` | |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/yunikorn-core/pull/426/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `69.39% <ø> (+0.01%)` | :arrow_up: |
| [pkg/scheduler/objects/node.go](https://codecov.io/gh/apache/yunikorn-core/pull/426/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL25vZGUuZ28=) | `81.49% <100.00%> (-1.20%)` | :arrow_down: |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org