You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/02/21 05:55:04 UTC
[GitHub] [iotdb] zhanglingzhe0820 opened a new pull request #2707: Fix merge delete cache bug
zhanglingzhe0820 opened a new pull request #2707:
URL: https://github.com/apache/iotdb/pull/2707
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #2707: [ISSUE-2709] Fix merge delete cache bug
Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #2707:
URL: https://github.com/apache/iotdb/pull/2707#issuecomment-784716104
Need to merge master branch again..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #2707: [ISSUE-2709] Fix merge delete cache bug
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #2707:
URL: https://github.com/apache/iotdb/pull/2707#discussion_r581524598
##########
File path: example/udf/pom.xml
##########
@@ -73,7 +73,7 @@
<importOrder>
<order>org.apache.iotdb,,javax,java,\#</order>
</importOrder>
- <removeUnusedImports/>
Review comment:
Don't change this...
##########
File path: pom.xml
##########
@@ -559,7 +559,6 @@
<exclude>**/.git/**</exclude>
<exclude>**/.mvn/**</exclude>
<exclude>**/.gitignore</exclude>
- <exclude>**/.git-blame-ignore-revs</exclude>
Review comment:
Same
##########
File path: pom.xml
##########
@@ -559,7 +559,6 @@
<exclude>**/.git/**</exclude>
<exclude>**/.mvn/**</exclude>
<exclude>**/.gitignore</exclude>
Review comment:
```suggestion
<exclude>**/.gitignore</exclude>
<exclude>**/.git-blame-ignore-revs</exclude>
```
##########
File path: pom.xml
##########
@@ -613,7 +612,7 @@
<importOrder>
<order>org.apache.iotdb,,javax,java,\#</order>
</importOrder>
- <removeUnusedImports/>
+ <removeUnusedImports />
Review comment:
```suggestion
<removeUnusedImports/>
```
##########
File path: example/udf/pom.xml
##########
@@ -73,7 +73,7 @@
<importOrder>
<order>org.apache.iotdb,,javax,java,\#</order>
</importOrder>
- <removeUnusedImports/>
+ <removeUnusedImports />
Review comment:
```suggestion
<removeUnusedImports/>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] zhanglingzhe0820 commented on pull request #2707: [ISSUE-2709,IOTDB-1178] Fix cache not cleared after unseq compaction bug, Fix windows 70,10 ci bug in unseq compaction ci
Posted by GitBox <gi...@apache.org>.
zhanglingzhe0820 commented on pull request #2707:
URL: https://github.com/apache/iotdb/pull/2707#issuecomment-787781318
cherry-pick to 0.11 [PR](https://github.com/apache/iotdb/pull/2749)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #2707: [ISSUE-2709] Fix merge delete cache bug
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #2707:
URL: https://github.com/apache/iotdb/pull/2707#discussion_r579822470
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/level/LevelCompactionTsFileManagement.java
##########
@@ -155,7 +157,9 @@ private void deleteLevelFilesInList(
private void deleteLevelFile(TsFileResource seqFile) {
seqFile.writeLock();
try {
+ ChunkCache.getInstance().clear();
Review comment:
clear all Cache?
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/level/LevelCompactionTsFileManagement.java
##########
@@ -155,7 +157,9 @@ private void deleteLevelFilesInList(
private void deleteLevelFile(TsFileResource seqFile) {
seqFile.writeLock();
try {
+ ChunkCache.getInstance().clear();
Review comment:
clean all Cache?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #2707: [ISSUE-2709] Fix merge delete cache bug
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #2707:
URL: https://github.com/apache/iotdb/pull/2707#discussion_r579822470
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/level/LevelCompactionTsFileManagement.java
##########
@@ -155,7 +157,9 @@ private void deleteLevelFilesInList(
private void deleteLevelFile(TsFileResource seqFile) {
seqFile.writeLock();
try {
+ ChunkCache.getInstance().clear();
Review comment:
clean the whole Cache?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #2707: [ISSUE-2709] Fix merge delete cache bug
Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #2707:
URL: https://github.com/apache/iotdb/pull/2707#issuecomment-784000073
Don't forget merge master branch....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #2707: [ISSUE-2709,IOTDB-1178] Fix cache not cleared after unseq compaction bug, Fix windows 70,10 ci bug in unseq compaction ci
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #2707:
URL: https://github.com/apache/iotdb/pull/2707
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org