You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "German Morales (JIRA)" <ji...@apache.org> on 2009/01/22 14:11:59 UTC

[jira] Created: (WICKET-2039) Fragment#getAssociatedMarkupStream() doesn't look for Parent in the proper way

Fragment#getAssociatedMarkupStream() doesn't look for Parent in the proper way
------------------------------------------------------------------------------

                 Key: WICKET-2039
                 URL: https://issues.apache.org/jira/browse/WICKET-2039
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.3.5
            Reporter: German Morales
            Priority: Minor


Fragment#getAssociatedMarkupStream, under certain conditions, decides to ask its parent for the AssociatedMarkupStream.

To do so, it uses the #getParent() method.

This is not always correct, because the Fragment's parent is not always a container with associated markup (for example, it could be a Form).

The problem can be easily fixed by using the #findParentWithAssociatedMarkup() method instead.

(See org.apache.wicket.markup.html.panel.Fragment.java, lines 344 and 346 in wicket 1.3.5)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-2039) Fragment#getAssociatedMarkupStream() doesn't look for Parent in the proper way

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/WICKET-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag resolved WICKET-2039.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4-RC2
         Assignee: Juergen Donnerstag

thanks

> Fragment#getAssociatedMarkupStream() doesn't look for Parent in the proper way
> ------------------------------------------------------------------------------
>
>                 Key: WICKET-2039
>                 URL: https://issues.apache.org/jira/browse/WICKET-2039
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.5
>            Reporter: German Morales
>            Assignee: Juergen Donnerstag
>            Priority: Minor
>             Fix For: 1.4-RC2
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> Fragment#getAssociatedMarkupStream, under certain conditions, decides to ask its parent for the AssociatedMarkupStream.
> To do so, it uses the #getParent() method.
> This is not always correct, because the Fragment's parent is not always a container with associated markup (for example, it could be a Form).
> The problem can be easily fixed by using the #findParentWithAssociatedMarkup() method instead.
> (See org.apache.wicket.markup.html.panel.Fragment.java, lines 344 and 346 in wicket 1.3.5)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.