You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Shubham Kumar <sh...@umail.iu.edu> on 2018/02/25 01:36:16 UTC
Review Request 65795: Adding warning to `apply-reviews.py` for
previously submitted patches.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65795/
-----------------------------------------------------------
Review request for mesos and Andrew Schwartzmeyer.
Bugs: MESOS-8586
https://issues.apache.org/jira/browse/MESOS-8586
Repository: mesos
Description
-------
This commit emits a warning when a chain skips submitted patches so
that the user is aware they were ignored.
Diffs
-----
support/apply-reviews.py 9fc1579f732609dac1b19ff5862f374e71e6cb53
Diff: https://reviews.apache.org/r/65795/diff/1/
Testing
-------
Test done.
command: ./support/apply-reviews.py -c -r 65397
output: Warning: Review 65397 has already been applied
Thanks,
Shubham Kumar
Re: Review Request 65795: Adding warning to `apply-reviews.py` for
previously submitted patches.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65795/#review198267
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65795]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 25, 2018, 9:36 a.m., Shubham Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65795/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2018, 9:36 a.m.)
>
>
> Review request for mesos and Andrew Schwartzmeyer.
>
>
> Bugs: MESOS-8586
> https://issues.apache.org/jira/browse/MESOS-8586
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit emits a warning when a chain skips submitted patches so
> that the user is aware they were ignored.
>
>
> Diffs
> -----
>
> support/apply-reviews.py 9fc1579f732609dac1b19ff5862f374e71e6cb53
>
>
> Diff: https://reviews.apache.org/r/65795/diff/1/
>
>
> Testing
> -------
>
> Test done.
>
> command: ./support/apply-reviews.py -c -r 65397
> output: Warning: Review 65397 has already been applied
>
>
> Thanks,
>
> Shubham Kumar
>
>
Re: Review Request 65795: Adding warning to `apply-reviews.py` for
previously submitted patches.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65795/#review198259
-----------------------------------------------------------
Ship it!
This address the first point of MESOS-8586 by warning the user that a patch (or patches) were skipped when applying a review chain if they were already submitted.
Note that the second point is left purposefully unaddressed, as the user will be warned it was already submitted, and then can use `git cherry-pick` to backport the patch.
- Andrew Schwartzmeyer
On Feb. 24, 2018, 5:36 p.m., Shubham Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65795/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2018, 5:36 p.m.)
>
>
> Review request for mesos and Andrew Schwartzmeyer.
>
>
> Bugs: MESOS-8586
> https://issues.apache.org/jira/browse/MESOS-8586
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit emits a warning when a chain skips submitted patches so
> that the user is aware they were ignored.
>
>
> Diffs
> -----
>
> support/apply-reviews.py 9fc1579f732609dac1b19ff5862f374e71e6cb53
>
>
> Diff: https://reviews.apache.org/r/65795/diff/1/
>
>
> Testing
> -------
>
> Test done.
>
> command: ./support/apply-reviews.py -c -r 65397
> output: Warning: Review 65397 has already been applied
>
>
> Thanks,
>
> Shubham Kumar
>
>
Re: Review Request 65795: Adding warning to `apply-reviews.py` for
previously submitted patches.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65795/#review198261
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65795']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65795
Relevant logs:
- [stout-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65795/logs/stout-tests-stdout.log):
```
[ RUN ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile
[ OK ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile (5 ms)
[ RUN ] RmdirTest.RemoveDirectoryButPreserveRoot
[ OK ] RmdirTest.RemoveDirectoryButPreserveRoot (5 ms)
[----------] 11 tests from RmdirTest (54 ms total)
[----------] 1 test from SocketTests
[ RUN ] SocketTests.InitSocket
[ OK ] SocketTests.InitSocket (1 ms)
[----------] 1 test from SocketTests (2 ms total)
[----------] 2 tests from StrerrorTest
[ RUN ] StrerrorTest.ValidErrno
[ OK ] StrerrorTest.ValidErrno (1 ms)
[ RUN ] StrerrorTest.InvalidErrno
[ OK ] StrerrorTest.InvalidErrno (0 ms)
[----------] 2 tests from StrerrorTest (2 ms total)
[----------] Global test environment tear-down
[==========] 273 tests from 46 test cases ran. (4146 ms total)
[ PASSED ] 270 tests.
[ FAILED ] 3 tests, listed below:
[ FAILED ] OsTest.SYMLINK_Realpath
[ FAILED ] FsTest.CreateDirectoryAtMaxPath
[ FAILED ] FsTest.CreateDirectoryLongerThanMaxPath
3 FAILED TESTS
YOU HAVE 7 DISABLED TESTS
```
- [stout-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65795/logs/stout-tests-stderr.log):
```
'invalid.command' is not recognized as an internal or external command,
operable program or batch file.
Subcommand 'subcommand' is not available
Usage: command <subcommand> [OPTIONS]
Available subcommands:
help
subcommand2
Multiple subcommands have name 'subcommand'
```
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65795/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (115 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (985 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (32 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (49 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (83 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2300 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2322 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2273 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2299 ms total)
[----------] Global test environment tear-down
[==========] 914 tests from 90 test cases ran. (419646 ms total)
[ PASSED ] 913 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] FilesTest.DebugTest
1 FAILED TEST
YOU HAVE 211 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65795/logs/mesos-tests-stderr.log):
```
I0225 03:10:23.642463 3596 master.cpp:10258] Updating the state of task 29ccdf9a-a775-4c98-a206-f1d9513f0877 of framework eeebbcc1-f807-47af-90cc-d9217e1a835f-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0225 03:10:23.642463 1020 slave.cpp:3879] Shutting down framework eeebbcc1-f807-47af-90cc-d9217e1a835f-0000
I0225 03:10:23.642463 1020 slave.cpp:6586] ShI0225 03:10:23.005475 6672 exec.cpp:162] Version: 1.6.0
I0225 03:10:23.029477 5100 exec.cpp:236] Executor registered on agent eeebbcc1-f807-47af-90cc-d9217e1a835f-S0
I0225 03:10:23.033478 7472 executor.cpp:174] Received SUBSCRIBED event
I0225 03:10:23.037477 7472 executor.cpp:178] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0225 03:10:23.037477 7472 executor.cpp:174] Received LAUNCH event
I0225 03:10:23.042454 7472 executor.cpp:646] Starting task 29ccdf9a-a775-4c98-a206-f1d9513f0877
I0225 03:10:23.116479 7472 executor.cpp:481] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0225 03:10:23.617491 7472 executor.cpp:659] Forked command at 7036
I0225 03:10:23.644464 1348 exec.cpp:445] Executor asked to shutdown
I0225 03:10:23.645464 7472 executor.cpp:174] Received SHUTDOWN event
I0225 03:10:23.645464 7472 executor.cpp:756] Shutting down
I0225 03:10:23.645464 7472 executor.cpp:866] Sending SIGTERM to process tree at pid 7utting down executor '29ccdf9a-a775-4c98-a206-f1d9513f0877' of framework eeebbcc1-f807-47af-90cc-d9217e1a835f-0000 at executor(1)@10.3.1.5:53610
I0225 03:10:23.643463 1020 slave.cpp:922] Agent terminating
W0225 03:10:23.644464 1020 slave.cpp:3875] Ignoring shutdown framework eeebbcc1-f807-47af-90cc-d9217e1a835f-0000 because it is terminating
I0225 03:10:23.644464 3596 master.cpp:10357] Removing task 29ccdf9a-a775-4c98-a206-f1d9513f0877 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework eeebbcc1-f807-47af-90cc-d9217e1a835f-0000 on agent eeebbcc1-f807-47af-90cc-d9217e1a835f-S0 at slave(398)@10.3.1.5:53589 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0225 03:10:23.646463 3596 master.cpp:1306] Agent eeebbcc1-f807-47af-90cc-d9217e1a835f-S0 at slave(398)@10.3.1.5:53589 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0225 03:10:23.646463 3596 master.cpp:3276] Disconnecting agent eeebbcc1-f807-47af-90cc-d9217e1a835f-S0 at slave(398)@10.3.1.5:53589 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0225 03:10:23.647464 3596 master.cpp:3295] Deactivating agent eeebbcc1-f807-47af-90cc-d9217e1a835f-S0 at slave(398)@10.3.1.5:53589 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0225 03:10:23.647464 8164 hierarchical.cpp:344] Removed framework eeebbcc1-f807-47af-90cc-d9217e1a835f-0000
I0225 03:10:23.647464 6004 containerizer.cpp:2338] Destroying container df40899e-135a-4a1d-8a43-9ae889a362fe in RUNNING state
I0225 03:10:23.647464 8164 hierarchical.cpp:766] Agent eeebbcc1-f807-47af-90cc-d9217e1a835f-S0 deactivated
I0225 03:10:23.647464 6004 containerizer.cpp:2952] Transitioning the state of container df40899e-135a-4a1d-8a43-9ae889a362fe from RUNNING to DESTROYING
I0225 03:10:23.648466 6004 launcher.cpp:156] Asked to destroy container df40899e-135a-4a1d-8a43-9ae889a362fe
I0225 03:10:23.750516 3596 containerizer.cpp:2791] Container df40899e-135a-4a1d-8a43-9ae889a362fe has exited
I0225 03:10:23.778874 6864 master.cpp:1149] Master terminating
I0225 03:10:23.780851 7728 hierarchical.cpp:609] Removed agent eeebbcc1-f807-47af-90cc-d9217e1a835f-S0
I0225 03:10:24.169865 2676 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Feb. 25, 2018, 1:36 a.m., Shubham Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65795/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2018, 1:36 a.m.)
>
>
> Review request for mesos and Andrew Schwartzmeyer.
>
>
> Bugs: MESOS-8586
> https://issues.apache.org/jira/browse/MESOS-8586
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit emits a warning when a chain skips submitted patches so
> that the user is aware they were ignored.
>
>
> Diffs
> -----
>
> support/apply-reviews.py 9fc1579f732609dac1b19ff5862f374e71e6cb53
>
>
> Diff: https://reviews.apache.org/r/65795/diff/1/
>
>
> Testing
> -------
>
> Test done.
>
> command: ./support/apply-reviews.py -c -r 65397
> output: Warning: Review 65397 has already been applied
>
>
> Thanks,
>
> Shubham Kumar
>
>
Re: Review Request 65795: Adding warning to `apply-reviews.py` for
previously submitted patches.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65795/#review198417
-----------------------------------------------------------
Fix it, then Ship it!
Thanks for your contribution!
support/apply-reviews.py
Lines 113-114 (patched)
<https://reviews.apache.org/r/65795/#comment278546>
The space between "already" and "been" should be moved to line 114 to be consistent with the style of the other messages.
- Gaston Kleiman
On Feb. 24, 2018, 5:36 p.m., Shubham Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65795/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2018, 5:36 p.m.)
>
>
> Review request for mesos and Andrew Schwartzmeyer.
>
>
> Bugs: MESOS-8586
> https://issues.apache.org/jira/browse/MESOS-8586
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit emits a warning when a chain skips submitted patches so
> that the user is aware they were ignored.
>
>
> Diffs
> -----
>
> support/apply-reviews.py 9fc1579f732609dac1b19ff5862f374e71e6cb53
>
>
> Diff: https://reviews.apache.org/r/65795/diff/1/
>
>
> Testing
> -------
>
> Test done.
>
> command: ./support/apply-reviews.py -c -r 65397
> output: Warning: Review 65397 has already been applied
>
>
> Thanks,
>
> Shubham Kumar
>
>