You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by sh...@apache.org on 2015/10/22 08:10:04 UTC
incubator-kylin git commit: KYLIN-1068 add debug
Repository: incubator-kylin
Updated Branches:
refs/heads/KYLIN-1068 bde043a01 -> 0d10b15b9
KYLIN-1068 add debug
Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/0d10b15b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/0d10b15b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/0d10b15b
Branch: refs/heads/KYLIN-1068
Commit: 0d10b15b992100b2b9692d805704033a3b1d386a
Parents: bde043a
Author: shaofengshi <sh...@apache.org>
Authored: Thu Oct 22 14:09:57 2015 +0800
Committer: shaofengshi <sh...@apache.org>
Committed: Thu Oct 22 14:09:57 2015 +0800
----------------------------------------------------------------------
.../java/org/apache/kylin/common/topn/TopNCounter.java | 3 +++
.../apache/kylin/cube/inmemcubing/InMemCubeBuilder.java | 12 +++++++-----
2 files changed, 10 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/0d10b15b/core-common/src/main/java/org/apache/kylin/common/topn/TopNCounter.java
----------------------------------------------------------------------
diff --git a/core-common/src/main/java/org/apache/kylin/common/topn/TopNCounter.java b/core-common/src/main/java/org/apache/kylin/common/topn/TopNCounter.java
index cc4780c..13c177f 100644
--- a/core-common/src/main/java/org/apache/kylin/common/topn/TopNCounter.java
+++ b/core-common/src/main/java/org/apache/kylin/common/topn/TopNCounter.java
@@ -301,10 +301,13 @@ public class TopNCounter<T> implements ITopK<T>, Iterable<Counter<T>> {
double[] counters = new double[size()];
int index = 0;
+ double last = Double.MIN_VALUE;
for (ListNode2<Counter<T>> bNode = counterList.tail(); bNode != null; bNode = bNode.getNext()) {
Counter<T> b = bNode.getValue();
counters[index] = b.count;
index++;
+ assert b.count > last;
+ last = b.count;
}
assert index == size();
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/0d10b15b/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java
----------------------------------------------------------------------
diff --git a/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java b/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java
index 62a6a5d..6962431 100644
--- a/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java
@@ -499,13 +499,15 @@ public class InMemCubeBuilder extends AbstractInMemCubeBuilder {
if (totalSum[i] instanceof DoubleMutable) {
totalSum[i] = Math.round(((DoubleMutable) totalSum[i]).get());
} else if (totalSum[i] instanceof TopNCounter) {
+ logger.info("sanityCheck on a TopNCounter");
TopNCounter counter = (TopNCounter) totalSum[i];
Iterator<Counter> iterator = counter.iterator();
double total = 0.0;
while (iterator.hasNext()) {
- total += iterator.next().getCount();
+ Counter aCounter = iterator.next();
+ logger.info("counter: " + aCounter.toString());
+ total += aCounter.getCount();
}
-
totalSum[i] = Math.round(total);
}
@@ -516,9 +518,9 @@ public class InMemCubeBuilder extends AbstractInMemCubeBuilder {
return;
}
if (Arrays.equals(totalSumForSanityCheck, totalSum) == false) {
- System.err.println("sanityCheck failed when calculate " + cuboidId + " from parent " + parentId);
- System.err.println("Expected: " + Arrays.toString(totalSumForSanityCheck));
- System.err.println("Actually: " + Arrays.toString(totalSum));
+ logger.info("sanityCheck failed when calculate " + cuboidId + " from parent " + parentId);
+ logger.info("Expected: " + Arrays.toString(totalSumForSanityCheck));
+ logger.info("Actually: " + Arrays.toString(totalSum));
throw new IllegalStateException();
}
}