You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/10/10 13:40:40 UTC

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #7535: [IOTDB-4205] Use logical path to take place of absolute path in snapshot log

xingtanzjr commented on code in PR #7535:
URL: https://github.com/apache/iotdb/pull/7535#discussion_r991301138


##########
server/src/main/java/org/apache/iotdb/db/engine/snapshot/SnapshotTaker.java:
##########
@@ -183,8 +186,8 @@ private void createHardLink(File target, File source) throws IOException {
       LOGGER.error("Hard link source file {} doesn't exist", source);
     }
     Files.deleteIfExists(target.toPath());
-    Files.createLink(target.getAbsoluteFile().toPath(), source.getAbsoluteFile().toPath());
-    snapshotLogger.logFile(source.getAbsolutePath(), target.getAbsolutePath());

Review Comment:
   Is this change equivalent with previous style ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org