You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/08/25 19:29:33 UTC

[kudu-CR] Deflake TabletCopyITest.TestRejectRogueLeader

Mike Percy has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7830

Change subject: Deflake TabletCopyITest.TestRejectRogueLeader
......................................................................

Deflake TabletCopyITest.TestRejectRogueLeader

The client was timing out waiting for a response to the old leader, who
was SIGSTOPed.

The thing that makes this not flaky anymore is:

  workload.set_timeout_allowed(true);

Change-Id: I8667b3e7aac9d5de6a6080ccca70de5f15e7cec7
---
M src/kudu/integration-tests/tablet_copy-itest.cc
1 file changed, 31 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/7830/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8667b3e7aac9d5de6a6080ccca70de5f15e7cec7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>

[kudu-CR] Deflake TabletCopyITest.TestRejectRogueLeader

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: Deflake TabletCopyITest.TestRejectRogueLeader
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8667b3e7aac9d5de6a6080ccca70de5f15e7cec7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Deflake TabletCopyITest.TestRejectRogueLeader

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.

Change subject: Deflake TabletCopyITest.TestRejectRogueLeader
......................................................................


Deflake TabletCopyITest.TestRejectRogueLeader

The client was timing out waiting for a response to the old leader, who
was SIGSTOPed.

The thing that makes this not flaky anymore is:

  workload.set_timeout_allowed(true);

Change-Id: I8667b3e7aac9d5de6a6080ccca70de5f15e7cec7
Reviewed-on: http://gerrit.cloudera.org:8080/7830
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Mike Percy <mp...@apache.org>
---
M src/kudu/integration-tests/tablet_copy-itest.cc
1 file changed, 31 insertions(+), 16 deletions(-)

Approvals:
  Mike Percy: Verified
  Todd Lipcon: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8667b3e7aac9d5de6a6080ccca70de5f15e7cec7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Deflake TabletCopyITest.TestRejectRogueLeader

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: Deflake TabletCopyITest.TestRejectRogueLeader
......................................................................


Patch Set 1:

Java tests failed, overriding jenkins

-- 
To view, visit http://gerrit.cloudera.org:8080/7830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8667b3e7aac9d5de6a6080ccca70de5f15e7cec7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Deflake TabletCopyITest.TestRejectRogueLeader

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: Deflake TabletCopyITest.TestRejectRogueLeader
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8667b3e7aac9d5de6a6080ccca70de5f15e7cec7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No