You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2019/03/30 20:09:00 UTC
[jira] [Commented] (HBASE-22137) [hbase-thirdparty] RC0 doesn't
include google.protobuf so fails PB generation if you try to use it.
[ https://issues.apache.org/jira/browse/HBASE-22137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805950#comment-16805950 ]
stack commented on HBASE-22137:
-------------------------------
Ok. In essence undoing the core of HBASE-18709. Will open new issue for 2.3.0 to work on undoing our dependence on these protos post-2.2.0.
{code}
--- a/hbase-shaded-protobuf/pom.xml
+++ b/hbase-shaded-protobuf/pom.xml
@@ -162,6 +162,9 @@
<exclude>com.google.errorprone.annotations.CanIgnoreReturnValue</exclude>
</excludes>
</relocation>
+ <!-- Our protos depend on the protos at this location.
+ TODO: We should move off depending on them and then
+ put this filter into place. See HBASE-22137.
<relocation>
<pattern>google.protobuf</pattern>
<shadedPattern>${rename.offset}.google.protobuf</shadedPattern>
@@ -169,12 +172,8 @@
<exclude>com.google.errorprone.annotations.CanIgnoreReturnValue</exclude>
</excludes>
</relocation>
+ -->
</relocations>
- <artifactSet>
- <excludes>
- <exclude>com.google.*:*</exclude>
- </excludes>
- </artifactSet>
</configuration>
</execution>
</executions>
{code}
> [hbase-thirdparty] RC0 doesn't include google.protobuf so fails PB generation if you try to use it.
> ---------------------------------------------------------------------------------------------------
>
> Key: HBASE-22137
> URL: https://issues.apache.org/jira/browse/HBASE-22137
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Major
> Fix For: thirdparty-2.2.0
>
>
> Tried to use the RC0. Build failed with this sort of stuff:
> {code}
> [INFO] --- protobuf-maven-plugin:0.5.0:compile (compile-protoc) @ hbase-protocol-shaded ---
> [INFO] Compiling 31 proto file(s) to /Users/stack/checkouts/hbase.git/hbase-protocol-shaded/target/generated-sources/protobuf/java
> [ERROR] PROTOC FAILED: google/protobuf/any.proto: File not found.
> Procedure.proto: Import "google/protobuf/any.proto" was not found or had errors.
> Procedure.proto:61:12: "google.protobuf.Any" is not defined.
> LockService.proto: Import "Procedure.proto" was not found or had errors.
> LockService.proto:86:12: "Procedure" is not defined.
> LockService.proto:88:12: "Procedure" is not defined.
> [ERROR] /Users/stack/checkouts/hbase.git/hbase-protocol-shaded/src/main/protobuf/Client.proto [0:0]: google/protobuf/any.proto: File not found.
> Procedure.proto: Import "google/protobuf/any.proto" was not found or had errors.
> Procedure.proto:61:12: "google.protobuf.Any" is not defined.
> LockService.proto: Import "Procedure.proto" was not found or had errors.
> LockService.proto:86:12: "Procedure" is not defined.
> LockService.proto:88:12: "Procedure" is not defined.
> [ERROR] /Users/stack/checkouts/hbase.git/hbase-protocol-shaded/src/main/protobuf/test_rpc_service.proto [0:0]: google/protobuf/any.proto: File not found.
> Procedure.proto: Import "google/protobuf/any.proto" was not found or had errors.
> Procedure.proto:61:12: "google.protobuf.Any" is not defined.
> LockService.proto: Import "Procedure.proto" was not found or had errors.
> LockService.proto:86:12: "Procedure" is not defined.
> LockService.proto:88:12: "Procedure" is not defined.
> ....
> {code}
> Its because of the HBASE-18709 Clean out bundled proto files changes.
> Let me revert them. Am afraid relocating will introduce interesting incompat issues.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)