You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by no...@apache.org on 2011/12/21 20:38:13 UTC

svn commit: r1221852 - in /james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api: BaseRequest.java ProtocolSession.java ProtocolTransport.java

Author: norman
Date: Wed Dec 21 19:38:12 2011
New Revision: 1221852

URL: http://svn.apache.org/viewvc?rev=1221852&view=rev
Log:
Remove @deprecated methods and add some javadocs

Modified:
    james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/BaseRequest.java
    james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/ProtocolSession.java
    james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/ProtocolTransport.java

Modified: james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/BaseRequest.java
URL: http://svn.apache.org/viewvc/james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/BaseRequest.java?rev=1221852&r1=1221851&r2=1221852&view=diff
==============================================================================
--- james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/BaseRequest.java (original)
+++ james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/BaseRequest.java Wed Dec 21 19:38:12 2011
@@ -50,7 +50,7 @@ public class BaseRequest implements Requ
 
 
     @Override
-    public String toString() {
+    public final String toString() {
         if (argument == null) {
             return command;
         } else {

Modified: james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/ProtocolSession.java
URL: http://svn.apache.org/viewvc/james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/ProtocolSession.java?rev=1221852&r1=1221851&r2=1221852&view=diff
==============================================================================
--- james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/ProtocolSession.java (original)
+++ james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/ProtocolSession.java Wed Dec 21 19:38:12 2011
@@ -58,26 +58,7 @@ public interface ProtocolSession {
      * Reset the state
      */
     void resetState();
-    
-    
-    /**
-     * Returns host name of the client
-     *
-     * @return hostname of the client
-     * @deprecated use {@link #getRemoteAddress()}
-     */
-    @Deprecated
-    String getRemoteHost();
 
-    /**
-     * Returns host ip address of the client
-     *
-     * @return host ip address of the client
-     * @deprecated use {@link #getRemoteAddress()}
-     */
-    @Deprecated
-    String getRemoteIPAddress();
-    
     
     /**
      * Return the {@link InetSocketAddress} of the remote peer

Modified: james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/ProtocolTransport.java
URL: http://svn.apache.org/viewvc/james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/ProtocolTransport.java?rev=1221852&r1=1221851&r2=1221852&view=diff
==============================================================================
--- james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/ProtocolTransport.java (original)
+++ james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/ProtocolTransport.java Wed Dec 21 19:38:12 2011
@@ -26,6 +26,8 @@ import org.apache.james.protocols.api.ha
 /**
  * ProtocolTransport is used by each ProtocolSession to communicate with the underlying transport.
  * Transport implementations will provide their own implementation of the transport.
+ * 
+ * Every new connection gets a new instance of {@link ProtocolTransport}. So its not shared between connections.
  */
 public interface ProtocolTransport {
 



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org