You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@qpid.apache.org by Chug Rolke <cr...@redhat.com> on 2013/11/18 19:48:47 UTC

Review Request 15652: C++ Broker - Restore deprecated Session statistic

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15652/
-----------------------------------------------------------

Review request for qpid and Ted Ross.


Bugs: QPID-5355
    https://issues.apache.org/jira/browse/QPID-5355


Repository: qpid


Description
-------

Restore deleted statistic; describe it as deprecated. The variable is unused and always has a value of zero.

Clients using 0.18 may expect to receive the statistic on updates and fail when it no longer exists.


Diffs
-----

  trunk/qpid/cpp/src/qpid/broker/management-schema.xml 1543103 

Diff: https://reviews.apache.org/r/15652/diff/


Testing
-------

Passes 'make test'. Variable exists with value of zero in all Sessions.


Thanks,

Chug Rolke

Re: Review Request 15652: C++ Broker - Restore deprecated Session statistic

Posted by Ted Ross <tr...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15652/#review29062
-----------------------------------------------------------

Ship it!


Whoever made the original change should be flogged.


- Ted Ross


On Nov. 18, 2013, 1:48 p.m., Chug Rolke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15652/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2013, 1:48 p.m.)
> 
> 
> Review request for qpid and Ted Ross.
> 
> 
> Bugs: QPID-5355
>     https://issues.apache.org/jira/browse/QPID-5355
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> Restore deleted statistic; describe it as deprecated. The variable is unused and always has a value of zero.
> 
> Clients using 0.18 may expect to receive the statistic on updates and fail when it no longer exists.
> 
> 
> Diffs
> -----
> 
>   trunk/qpid/cpp/src/qpid/broker/management-schema.xml 1543103 
> 
> Diff: https://reviews.apache.org/r/15652/diff/
> 
> 
> Testing
> -------
> 
> Passes 'make test'. Variable exists with value of zero in all Sessions.
> 
> 
> Thanks,
> 
> Chug Rolke
> 
>