[GitHub] ok2c commented on a change in pull request #140: HTTPCLIENT-1969: Filter out weak cipher suites

[GitBox <gi...@apache.org>]

ok2c commented on a change in pull request #140: HTTPCLIENT-1969: Filter out weak cipher suites
URL: https://github.com/apache/httpcomponents-client/pull/140#discussion_r261690315
 
 

 ##########
 File path: httpclient/src/main/java/org/apache/http/conn/ssl/SSLConnectionSocketFactory.java
 ##########
 @@ -183,6 +187,15 @@ public static SSLConnectionSocketFactory getSocketFactory() throws SSLInitializa
         return new SSLConnectionSocketFactory(SSLContexts.createDefault(), getDefaultHostnameVerifier());
     }
 
+    private static boolean isWeakCipherSuite(final String cipherSuite) {
+        for (final String weakAlgorithm : WEAK_ALGORITHMS) {
+            if (cipherSuite.contains(weakAlgorithm)) {
 
 Review comment:
   @artem-smotrakov Could this be replaced with regexp matching?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org