You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Harish Butani <rh...@gmail.com> on 2013/10/29 22:17:30 UTC

Review Request 15055: HIVE-5557: Push down qualifying Where clause predicates as join conditions

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15055/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Bugs: hive-5557
    https://issues.apache.org/jira/browse/hive-5557


Repository: hive-git


Description
-------

Step 2 of HIVE-5555.
Depends on HIVE-5556


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cf0c895 
  ql/src/test/queries/clientpositive/join_cond_pushdown_3.q PRE-CREATION 
  ql/src/test/queries/clientpositive/join_cond_pushdown_4.q PRE-CREATION 
  ql/src/test/results/clientpositive/join_cond_pushdown_3.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/join_cond_pushdown_4.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/15055/diff/


Testing
-------

ran all join tests
added 2 new tests join_cond_pushdown3.q, join_cond_pushdown4.q


Thanks,

Harish Butani

Re: Review Request 15055: HIVE-5557: Push down qualifying Where clause predicates as join conditions

Posted by Harish Butani <rh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15055/
-----------------------------------------------------------

(Updated Nov. 7, 2013, 10:04 p.m.)


Review request for hive, Ashutosh Chauhan and Vikram Dixit Kumaraswamy.


Changes
-------

fix diff in bucketizedhiveinputformat.q


Bugs: hive-5557
    https://issues.apache.org/jira/browse/hive-5557


Repository: hive-git


Description
-------

Step 2 of HIVE-5555.
Depends on HIVE-5556


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 5305537 
  ql/src/test/queries/clientpositive/join_cond_pushdown_3.q PRE-CREATION 
  ql/src/test/queries/clientpositive/join_cond_pushdown_4.q PRE-CREATION 
  ql/src/test/results/clientpositive/bucketizedhiveinputformat.q.out 4aa9fa7 
  ql/src/test/results/clientpositive/join_cond_pushdown_3.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/join_cond_pushdown_4.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/sample8.q.out 60e0831 

Diff: https://reviews.apache.org/r/15055/diff/


Testing
-------

ran all join tests
added 2 new tests join_cond_pushdown3.q, join_cond_pushdown4.q


Thanks,

Harish Butani

Re: Review Request 15055: HIVE-5557: Push down qualifying Where clause predicates as join conditions

Posted by Harish Butani <rh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15055/
-----------------------------------------------------------

(Updated Nov. 6, 2013, 1:11 a.m.)


Review request for hive, Ashutosh Chauhan and Vikram Dixit Kumaraswamy.


Changes
-------

fix out files for new tests: load path has changed
fix output of sample8.q


Bugs: hive-5557
    https://issues.apache.org/jira/browse/hive-5557


Repository: hive-git


Description
-------

Step 2 of HIVE-5555.
Depends on HIVE-5556


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 5305537 
  ql/src/test/queries/clientpositive/join_cond_pushdown_3.q PRE-CREATION 
  ql/src/test/queries/clientpositive/join_cond_pushdown_4.q PRE-CREATION 
  ql/src/test/results/clientpositive/join_cond_pushdown_3.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/join_cond_pushdown_4.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/sample8.q.out 60e0831 

Diff: https://reviews.apache.org/r/15055/diff/


Testing
-------

ran all join tests
added 2 new tests join_cond_pushdown3.q, join_cond_pushdown4.q


Thanks,

Harish Butani

Re: Review Request 15055: HIVE-5557: Push down qualifying Where clause predicates as join conditions

Posted by Harish Butani <rh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15055/
-----------------------------------------------------------

(Updated Oct. 29, 2013, 9:20 p.m.)


Review request for hive, Ashutosh Chauhan and Vikram Dixit Kumaraswamy.


Bugs: hive-5557
    https://issues.apache.org/jira/browse/hive-5557


Repository: hive-git


Description
-------

Step 2 of HIVE-5555.
Depends on HIVE-5556


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cf0c895 
  ql/src/test/queries/clientpositive/join_cond_pushdown_3.q PRE-CREATION 
  ql/src/test/queries/clientpositive/join_cond_pushdown_4.q PRE-CREATION 
  ql/src/test/results/clientpositive/join_cond_pushdown_3.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/join_cond_pushdown_4.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/15055/diff/


Testing
-------

ran all join tests
added 2 new tests join_cond_pushdown3.q, join_cond_pushdown4.q


Thanks,

Harish Butani