You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yiguolei (via GitHub)" <gi...@apache.org> on 2023/08/05 10:11:30 UTC
[GitHub] [doris] yiguolei commented on a diff in pull request #22635: [fix](planner) should not change SlotRef to NullLiteral
yiguolei commented on code in PR #22635:
URL: https://github.com/apache/doris/pull/22635#discussion_r1285014572
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java:
##########
@@ -934,7 +934,7 @@ public TExpr treeToThrift() {
// being cast to a non-NULL type, the type doesn't matter and we can cast it
// arbitrarily.
Preconditions.checkState(this instanceof NullLiteral || this instanceof SlotRef);
- return NullLiteral.create(ScalarType.BOOLEAN).treeToThrift();
+ type = ScalarType.BOOLEAN;
Review Comment:
Could add some regression tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org