You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/22 18:42:02 UTC

[GitHub] twalthr opened a new pull request #6897: [FLINK-9737] [FLINK-8880] [sql-client] Support defining temporal tables in environment files

twalthr opened a new pull request #6897: [FLINK-9737] [FLINK-8880] [sql-client] Support defining temporal tables in environment files
URL: https://github.com/apache/flink/pull/6897
 
 
   ## What is the purpose of the change
   
   This PR introduces the definition of temporal tables also to the SQL Client. Similar to table views, temporal table definitions need to reference a different table source or table view. Thus, the definition order is important which is why this code refactors the parsing of environment files. The recently introduced top-level section `views` has been integrated into `tables`; temporal tables are defined there as well. As a side effect of the refactoring, properties are also validated for data type and value bounds now.
   
   This PR depends on #6893.
   
   ## Brief change log
   
   - Additional auxiliary methods for property handling
   - Refactoring for similar treatment of table sources, sinks, source-sinks, views, and temporal tables
   - Introduction of a basic validation for all configuration entries
   
   ## Verifying this change
   
   - `org.apache.flink.table.client.gateway.local.ExecutionContextTest` has been extended
   - Existing tests have been slightly refactored
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? docs
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services