You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/01/29 17:27:32 UTC
[kudu-CR] [cmake modules] fix GET LINKER VERSION on macOS Catalina
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15129
Change subject: [cmake_modules] fix GET_LINKER_VERSION on macOS Catalina
......................................................................
[cmake_modules] fix GET_LINKER_VERSION on macOS Catalina
On macOS Catalina the linker version is currently `530`.
The current regex requires a second version component.
The result is an error that looks like the following:
CMake Error at cmake_modules/KuduLinker.cmake:160 (message):
Could not extract ld64 version. Linker version output:
Call Stack (most recent call first):
cmake_modules/KuduLinker.cmake:36 (GET_LINKER_VERSION)
CMakeLists.txt:398 (APPEND_LINKER_FLAGS)
To fix this the regex was updated to make the second version
component optional.
Change-Id: I11b43153279cc44766f5f03c7d59808d555d9321
---
M cmake_modules/KuduLinker.cmake
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/15129/1
--
To view, visit http://gerrit.cloudera.org:8080/15129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11b43153279cc44766f5f03c7d59808d555d9321
Gerrit-Change-Number: 15129
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [cmake modules] fix GET LINKER VERSION on macOS Catalina
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15129 )
Change subject: [cmake_modules] fix GET_LINKER_VERSION on macOS Catalina
......................................................................
[cmake_modules] fix GET_LINKER_VERSION on macOS Catalina
On macOS Catalina the linker version is currently `530`.
The current regex requires a second version component.
The result is an error that looks like the following:
CMake Error at cmake_modules/KuduLinker.cmake:160 (message):
Could not extract ld64 version. Linker version output:
Call Stack (most recent call first):
cmake_modules/KuduLinker.cmake:36 (GET_LINKER_VERSION)
CMakeLists.txt:398 (APPEND_LINKER_FLAGS)
To fix this the regex was updated to make the second version
component optional.
Change-Id: I11b43153279cc44766f5f03c7d59808d555d9321
Reviewed-on: http://gerrit.cloudera.org:8080/15129
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M cmake_modules/KuduLinker.cmake
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I11b43153279cc44766f5f03c7d59808d555d9321
Gerrit-Change-Number: 15129
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [cmake modules] fix GET LINKER VERSION on macOS Catalina
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15129 )
Change subject: [cmake_modules] fix GET_LINKER_VERSION on macOS Catalina
......................................................................
Patch Set 1: Code-Review+2
Thank you for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/15129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b43153279cc44766f5f03c7d59808d555d9321
Gerrit-Change-Number: 15129
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 29 Jan 2020 17:41:04 +0000
Gerrit-HasComments: No