You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2016/01/04 05:52:30 UTC
Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41762/
-----------------------------------------------------------
(Updated Jan. 3, 2016, 8:52 p.m.)
Review request for Aurora, John Sirois and Zameer Manji.
Changes
-------
Added NEWS entry.
Repository: aurora
Description
-------
Primary motivation here is to get past 3.4.0, which changed how logging works in ZK (primarily via slf4j). This will make it easier to have a cohesive logging story.
There was some fallout - I did not update to latest - 3.4.7. I encountered issues with a kerberos-related test (see comment in `build.gradle`) with >=3.4.3. I spent a few minutes looking for a solution, but decided to stop short so as to return to the work i was really trying to tackle.
Diffs (updated)
-----
NEWS 394b31cf1c863c54b89e7f27ab3694bdd51b2eeb
build.gradle 5ff10d90fa8f748b066faf1c4ec385b22dd883b4
commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 03d47c37f67dee64eca2107ab1510c7efcdd0931
Diff: https://reviews.apache.org/r/41762/diff/
Testing
-------
end-to-end tests
Thanks,
Bill Farner
Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41762/
-----------------------------------------------------------
(Updated Jan. 3, 2016, 8:55 p.m.)
Review request for Aurora, John Sirois and Zameer Manji.
Changes
-------
+rebase
Repository: aurora
Description
-------
Primary motivation here is to get past 3.4.0, which changed how logging works in ZK (primarily via slf4j). This will make it easier to have a cohesive logging story.
There was some fallout - I did not update to latest - 3.4.7. I encountered issues with a kerberos-related test (see comment in `build.gradle`) with >=3.4.3. I spent a few minutes looking for a solution, but decided to stop short so as to return to the work i was really trying to tackle.
Diffs (updated)
-----
NEWS 965fbf41d11296b08cdc722cfece9e37e49dbb6e
build.gradle 6f89958c3845f01830f792cc78a755542b41e162
commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 03d47c37f67dee64eca2107ab1510c7efcdd0931
Diff: https://reviews.apache.org/r/41762/diff/
Testing
-------
end-to-end tests
Thanks,
Bill Farner