You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/07/30 03:21:52 UTC

[GitHub] [druid] FrankChen021 commented on pull request #11257: Reduce method invocation of reservoir sampling

FrankChen021 commented on pull request #11257:
URL: https://github.com/apache/druid/pull/11257#issuecomment-889599447


   @yuanlihan Great work. Code change LGTM.  For benchmark, could you add a combination of `50percentOfSegmentsToConsiderPerMove` and `useBatchedSegmentSampler` so that we could see how `percentOfSegmentsToConsider` improves the performance based on the new algorithm. This benchmark could help us to determine whether we need to keep `percentOfSegmentsToConsider` in future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org