[jira] Resolved: (MYFACES-462) UIComponent.processSaveState implementation not correct

["Oliver Rossmueller (JIRA)" <my...@incubator.apache.org>]

     [ http://issues.apache.org/jira/browse/MYFACES-462?page=all ]
     
Oliver Rossmueller resolved MYFACES-462:
----------------------------------------

    Resolution: Fixed

This issue is related to UIComponent.processSaveState and not StateHolder.isTransient or StateHolder.saveState so I suppose my fix follows the spec.

I removed the transient check from processRestoreState, though, as this check is redundant there: transient components are not stored by definition so there cannot be a transient component in the view state to be restored

> UIComponent.processSaveState implementation not correct
> -------------------------------------------------------
>
>          Key: MYFACES-462
>          URL: http://issues.apache.org/jira/browse/MYFACES-462
>      Project: MyFaces
>         Type: Bug
>   Components: JSR-127
>     Versions: Nightly Build
>     Reporter: Oliver Rossmueller
>     Assignee: Oliver Rossmueller
>      Fix For: Nightly Build

>
> I think the test for child.isTransient in line 449 of UIComponentBase has to be removed as the javadoc says
>         * Call the processSaveState() method of all facets and children of this UIComponent in the order determined by a call to getFacetsAndChildren().
> There is no "unless the facet of child is transient" so processSaveState has to be called for all facets/children whether they are transient or not

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira