You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/12 13:17:33 UTC
[GitHub] [pulsar] congbobo184 opened a new pull request #14667: [Transaction] Fix cursor readPosition is bigger than maxPosition in O…
congbobo184 opened a new pull request #14667:
URL: https://github.com/apache/pulsar/pull/14667
### Motivation
Fix cursor read op dead loop.
### Modifications
1. in OpReadEntry we can't use cursor readPosition, because it is not the OpReadEntry readPosition, it is cursor readPosition when one ledger is empty the OpReadEntry readPosition is not equals cursor readPosition, we should use OpReadEntry readPosition to judge the OpReadEntry can be finished.
2. when readPosition is bigger than maxPosition in OpReadEntry, we should complete this OpReadEntry
### Verifying this change
add test
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 merged pull request #14667: [Transaction] Fix cursor readPosition is bigger than maxPosition in OpReadEntry
Posted by GitBox <gi...@apache.org>.
congbobo184 merged pull request #14667:
URL: https://github.com/apache/pulsar/pull/14667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14667: [Transaction] Fix cursor readPosition is bigger than maxPosition in O…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14667:
URL: https://github.com/apache/pulsar/pull/14667#issuecomment-1065882811
@congbobo184:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14667: [Transaction] Fix cursor readPosition is bigger than maxPosition in O…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14667:
URL: https://github.com/apache/pulsar/pull/14667#issuecomment-1065882126
@congbobo184:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #14667: [Transaction] Fix cursor readPosition is bigger than maxPosition in O…
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #14667:
URL: https://github.com/apache/pulsar/pull/14667#discussion_r825306594
##########
File path: managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java
##########
@@ -3710,5 +3708,45 @@ public void testCursorNoRolloverIfNoMetadataSession() throws Exception {
assertNotEquals(cursor.getCursorLedger(), initialLedgerId);
}
+ @Test
+ public void testReadEmptyEntryList() throws Exception {
+ ManagedLedgerConfig managedLedgerConfig = new ManagedLedgerConfig();
+ managedLedgerConfig.setMaxEntriesPerLedger(1);
+ managedLedgerConfig.setMetadataMaxEntriesPerLedger(1);
+ managedLedgerConfig.setMinimumRolloverTime(0, TimeUnit.MILLISECONDS);
+ ManagedLedgerImpl ledger = (ManagedLedgerImpl) factory
+ .open("testReadEmptyEntryList", managedLedgerConfig);
+ ManagedCursorImpl cursor = (ManagedCursorImpl) ledger.openCursor("test");
+
+ PositionImpl lastPosition = (PositionImpl) ledger.addEntry("test".getBytes(Encoding));
+ ledger.rollCurrentLedgerIfFull();
+
+ AtomicBoolean flag = new AtomicBoolean();
+ flag.set(false);
+ ReadEntriesCallback callback = new ReadEntriesCallback() {
+ @Override
+ public void readEntriesComplete(List<Entry> entries, Object ctx) {
+ if (entries.size() == 0) {
+ flag.set(true);
+ }
+ }
+
+ @Override
+ public void readEntriesFailed(ManagedLedgerException exception, Object ctx) {
+
+ }
+ };
+
+ // op readPosition is bigger than maxReadPosition
+ OpReadEntry opReadEntry = OpReadEntry.create(cursor, ledger.lastConfirmedEntry, 10, callback,
+ null, PositionImpl.get(lastPosition.getLedgerId(), -1));
+ ledger.asyncReadEntries(opReadEntry);
+
+ // when readPosition is bigger than maxReadPosition, should complete the opReadEntry
+ Awaitility.await().untilAsserted(() -> assertTrue(flag.get()));
+ }
+
+
Review comment:
Remove these lines.
##########
File path: managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java
##########
@@ -3710,5 +3708,45 @@ public void testCursorNoRolloverIfNoMetadataSession() throws Exception {
assertNotEquals(cursor.getCursorLedger(), initialLedgerId);
}
+ @Test
+ public void testReadEmptyEntryList() throws Exception {
Review comment:
Without the changes of the PR, the test can get passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org