You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by db...@apache.org on 2017/03/07 01:25:22 UTC

svn commit: r1785790 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/query/UserQueryManager.java

Author: dbrosius
Date: Tue Mar  7 01:25:22 2017
New Revision: 1785790

URL: http://svn.apache.org/viewvc?rev=1785790&view=rev
Log:
avoid creating condition visitor if there are no conditions

Modified:
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/query/UserQueryManager.java

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/query/UserQueryManager.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/query/UserQueryManager.java?rev=1785790&r1=1785789&r2=1785790&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/query/UserQueryManager.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/query/UserQueryManager.java Tue Mar  7 01:25:22 2017
@@ -251,13 +251,13 @@ public class UserQueryManager {
         }
 
         StringBuilder statement = new StringBuilder();
-        ConditionVisitor visitor = new XPathConditionVisitor(statement, namePathMapper, userManager);
-
+ 
         String searchRoot = namePathMapper.getJcrPath(QueryUtil.getSearchRoot(builder.getSelectorType(), config));
         String ntName = namePathMapper.getJcrName(QueryUtil.getNodeTypeName(builder.getSelectorType()));
         statement.append(searchRoot).append("//element(*,").append(ntName).append(')');
 
         if (condition != null) {
+            ConditionVisitor visitor = new XPathConditionVisitor(statement, namePathMapper, userManager);
             statement.append('[');
             condition.accept(visitor);
             statement.append(']');
@@ -342,4 +342,4 @@ public class UserQueryManager {
             return false;
         }
     }
-}
\ No newline at end of file
+}