You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Don Ngo (JIRA)" <ji...@apache.org> on 2011/07/11 17:18:00 UTC
[jira] [Created] (WICKET-3886) Option for providing caption to
DataTable
Option for providing caption to DataTable
-----------------------------------------
Key: WICKET-3886
URL: https://issues.apache.org/jira/browse/WICKET-3886
Project: Wicket
Issue Type: Bug
Affects Versions: 1.5-RC5.1
Reporter: Don Ngo
Priority: Minor
Please consider adding an option for providing the value for the caption tag in the DataTable class. Doing so will allow us to have data table like below:
<table>
<caption>Some caption>
<thead>
...
</thead>
</table>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-3886) Option for providing caption to
DataTable
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-3886.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-RC6
Assignee: Martin Grigorov
Implemented with r1148307.
Override DataTable#getCaptionModel() to return non-empty model object and it will be used as a caption.
> Option for providing caption to DataTable
> -----------------------------------------
>
> Key: WICKET-3886
> URL: https://issues.apache.org/jira/browse/WICKET-3886
> Project: Wicket
> Issue Type: New Feature
> Affects Versions: 1.5-RC5.1
> Reporter: Don Ngo
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 1.5-RC6
>
>
> Please consider adding an option for providing the value for the caption tag in the DataTable class. Doing so will allow us to have data table like below:
> <table>
> <caption>Some caption<caption>
> <thead>
> ...
> </thead>
> <tfooter>
> ...
> </tfooter>
> <tbody>
> ...
> </tbody>
> </table>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3886) Option for providing caption to
DataTable
Posted by "Adriano dos Santos Fernandes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068352#comment-13068352 ]
Adriano dos Santos Fernandes commented on WICKET-3886:
------------------------------------------------------
This patch fixes the problem.
diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DataTable.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DataTable.java
index 9c9861c..15f9d7f 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DataTable.java
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DataTable.java
@@ -33,6 +33,7 @@ import org.apache.wicket.markup.repeater.RefreshingView;
import org.apache.wicket.markup.repeater.RepeatingView;
import org.apache.wicket.markup.repeater.data.IDataProvider;
import org.apache.wicket.model.IModel;
+import org.apache.wicket.model.Model;
import org.apache.wicket.util.string.Strings;
import org.apache.wicket.util.visit.IVisit;
import org.apache.wicket.util.visit.IVisitor;
@@ -193,7 +194,7 @@ public class DataTable<T> extends Panel implements IPageableItems
*/
protected IModel<String> getCaptionModel()
{
- return null;
+ return Model.of("");
}
/**
> Option for providing caption to DataTable
> -----------------------------------------
>
> Key: WICKET-3886
> URL: https://issues.apache.org/jira/browse/WICKET-3886
> Project: Wicket
> Issue Type: New Feature
> Affects Versions: 1.5-RC5.1
> Reporter: Don Ngo
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 1.5-RC6
>
>
> Please consider adding an option for providing the value for the caption tag in the DataTable class. Doing so will allow us to have data table like below:
> <table>
> <caption>Some caption<caption>
> <thead>
> ...
> </thead>
> <tfooter>
> ...
> </tfooter>
> <tbody>
> ...
> </tbody>
> </table>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3886) Option for providing caption to
DataTable
Posted by "Don Ngo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Ngo updated WICKET-3886:
----------------------------
Description:
Please consider adding an option for providing the value for the caption tag in the DataTable class. Doing so will allow us to have data table like below:
<table>
<caption>Some caption<caption>
<thead>
...
</thead>
<tfooter>
...
</tfooter>
<tbody>
...
</tbody>
</table>
was:
Please consider adding an option for providing the value for the caption tag in the DataTable class. Doing so will allow us to have data table like below:
<table>
<caption>Some caption<caption>
<thead>
...
</thead>
</table>
> Option for providing caption to DataTable
> -----------------------------------------
>
> Key: WICKET-3886
> URL: https://issues.apache.org/jira/browse/WICKET-3886
> Project: Wicket
> Issue Type: New Feature
> Affects Versions: 1.5-RC5.1
> Reporter: Don Ngo
> Priority: Minor
>
> Please consider adding an option for providing the value for the caption tag in the DataTable class. Doing so will allow us to have data table like below:
> <table>
> <caption>Some caption<caption>
> <thead>
> ...
> </thead>
> <tfooter>
> ...
> </tfooter>
> <tbody>
> ...
> </tbody>
> </table>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3886) Option for providing caption to
DataTable
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068342#comment-13068342 ]
Martin Grigorov commented on WICKET-3886:
-----------------------------------------
Fixed with r1148746.
Thanks!
> Option for providing caption to DataTable
> -----------------------------------------
>
> Key: WICKET-3886
> URL: https://issues.apache.org/jira/browse/WICKET-3886
> Project: Wicket
> Issue Type: New Feature
> Affects Versions: 1.5-RC5.1
> Reporter: Don Ngo
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 1.5-RC6
>
>
> Please consider adding an option for providing the value for the caption tag in the DataTable class. Doing so will allow us to have data table like below:
> <table>
> <caption>Some caption<caption>
> <thead>
> ...
> </thead>
> <tfooter>
> ...
> </tfooter>
> <tbody>
> ...
> </tbody>
> </table>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3886) Option for providing caption to
DataTable
Posted by "Don Ngo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Ngo updated WICKET-3886:
----------------------------
Description:
Please consider adding an option for providing the value for the caption tag in the DataTable class. Doing so will allow us to have data table like below:
<table>
<caption>Some caption<caption>
<thead>
...
</thead>
</table>
was:
Please consider adding an option for providing the value for the caption tag in the DataTable class. Doing so will allow us to have data table like below:
<table>
<caption>Some caption>
<thead>
...
</thead>
</table>
> Option for providing caption to DataTable
> -----------------------------------------
>
> Key: WICKET-3886
> URL: https://issues.apache.org/jira/browse/WICKET-3886
> Project: Wicket
> Issue Type: New Feature
> Affects Versions: 1.5-RC5.1
> Reporter: Don Ngo
> Priority: Minor
>
> Please consider adding an option for providing the value for the caption tag in the DataTable class. Doing so will allow us to have data table like below:
> <table>
> <caption>Some caption<caption>
> <thead>
> ...
> </thead>
> </table>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3886) Option for providing caption to
DataTable
Posted by "Adriano dos Santos Fernandes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068355#comment-13068355 ]
Adriano dos Santos Fernandes commented on WICKET-3886:
------------------------------------------------------
Ok, I didn't saw you already fixed it!
Thanks.
> Option for providing caption to DataTable
> -----------------------------------------
>
> Key: WICKET-3886
> URL: https://issues.apache.org/jira/browse/WICKET-3886
> Project: Wicket
> Issue Type: New Feature
> Affects Versions: 1.5-RC5.1
> Reporter: Don Ngo
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 1.5-RC6
>
>
> Please consider adding an option for providing the value for the caption tag in the DataTable class. Doing so will allow us to have data table like below:
> <table>
> <caption>Some caption<caption>
> <thead>
> ...
> </thead>
> <tfooter>
> ...
> </tfooter>
> <tbody>
> ...
> </tbody>
> </table>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3886) Option for providing caption to
DataTable
Posted by "Adriano dos Santos Fernandes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068339#comment-13068339 ]
Adriano dos Santos Fernandes commented on WICKET-3886:
------------------------------------------------------
The implementation broke datatable used with CompoundPropertyModel, as it's trying to access non-existent 'caption' property because the model is null.
> Option for providing caption to DataTable
> -----------------------------------------
>
> Key: WICKET-3886
> URL: https://issues.apache.org/jira/browse/WICKET-3886
> Project: Wicket
> Issue Type: New Feature
> Affects Versions: 1.5-RC5.1
> Reporter: Don Ngo
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 1.5-RC6
>
>
> Please consider adding an option for providing the value for the caption tag in the DataTable class. Doing so will allow us to have data table like below:
> <table>
> <caption>Some caption<caption>
> <thead>
> ...
> </thead>
> <tfooter>
> ...
> </tfooter>
> <tbody>
> ...
> </tbody>
> </table>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3886) Option for providing caption to
DataTable
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-3886:
------------------------------------
Issue Type: New Feature (was: Bug)
> Option for providing caption to DataTable
> -----------------------------------------
>
> Key: WICKET-3886
> URL: https://issues.apache.org/jira/browse/WICKET-3886
> Project: Wicket
> Issue Type: New Feature
> Affects Versions: 1.5-RC5.1
> Reporter: Don Ngo
> Priority: Minor
>
> Please consider adding an option for providing the value for the caption tag in the DataTable class. Doing so will allow us to have data table like below:
> <table>
> <caption>Some caption>
> <thead>
> ...
> </thead>
> </table>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira