You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/17 02:10:47 UTC
[GitHub] [dolphinscheduler] Dannila opened a new issue, #10049: [BUG] [Plugin] Conditions Task branch flow failed
Dannila opened a new issue, #10049:
URL: https://github.com/apache/dolphinscheduler/issues/10049
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.
### What you expected to happen
The Condition task should decide which downstream task should run based on the conditions of the upstream task.
### How to reproduce
Create a Condition task, determine the successful or failed branch task and run it。
When the upstream task runs successfully, Conditions select the successful branch task and run it.
But when the upstream task fails to run, Conditions still select the successful branch task and run it.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10049: [BUG] [Plugin] Conditions Task branch flow failed
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10049:
URL: https://github.com/apache/dolphinscheduler/issues/10049#issuecomment-1128749809
I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fhygh commented on issue #10049: [BUG] [Plugin] Conditions Task branch flow failed
Posted by GitBox <gi...@apache.org>.
fhygh commented on issue #10049:
URL: https://github.com/apache/dolphinscheduler/issues/10049#issuecomment-1151020621
@SbloodyS i tried in 3.0.0 beta version, which merged the code of [https://github.com/apache/dolphinscheduler/pull/10077](url), but condition task plugin is still not work fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] huangchenguang123 commented on issue #10049: [BUG] [Plugin] Conditions Task branch flow failed
Posted by GitBox <gi...@apache.org>.
huangchenguang123 commented on issue #10049:
URL: https://github.com/apache/dolphinscheduler/issues/10049#issuecomment-1128762075
> I will fix it.
Conditions should use previousNodes result, and now use dependency result? I find add Custom Parameters can make it trigger fail Node....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie closed issue #10049: [BUG] [Plugin] Conditions Task branch flow failed
Posted by GitBox <gi...@apache.org>.
zhongjiajie closed issue #10049: [BUG] [Plugin] Conditions Task branch flow failed
URL: https://github.com/apache/dolphinscheduler/issues/10049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10049: [BUG] [Plugin] Conditions Task branch flow failed
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10049:
URL: https://github.com/apache/dolphinscheduler/issues/10049#issuecomment-1151078206
I've tried condition tasks in the latest dev branch. It works fine. @fhygh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fhygh commented on issue #10049: [BUG] [Plugin] Conditions Task branch flow failed
Posted by GitBox <gi...@apache.org>.
fhygh commented on issue #10049:
URL: https://github.com/apache/dolphinscheduler/issues/10049#issuecomment-1151784850
@SbloodyS oh, i see, need add pre task, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] huangchenguang123 commented on issue #10049: [BUG] [Plugin] Conditions Task branch flow failed
Posted by GitBox <gi...@apache.org>.
huangchenguang123 commented on issue #10049:
URL: https://github.com/apache/dolphinscheduler/issues/10049#issuecomment-1129119855
> > > I will fix it.
> >
> >
> > Conditions should use previousNodes result, and now only use dependency result? I find add Custom Parameters can make it trigger fail Node....May be #10077 should use previousNodes and/or Custom Parameters? This is my doubt, don't mind if I'm wrong.
>
> Yes. In this PR, I change the detection logic to use previousNodes to check condition instead of use dependency result.
>
> However, I don't think the success or failure of task nodes should be related to user-defined parameters.
The Condition's Custom Parameters is different from other, it's has and/or relation with pre node in ui(it's also only has success and failure), and when i run the task, these Custom Parameters will be used in dependencyList, this is why i think they should be calculate together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #10049: [BUG] [Plugin] Conditions Task branch flow failed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #10049:
URL: https://github.com/apache/dolphinscheduler/issues/10049#issuecomment-1128325627
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://join.slack.com/t/asf-dolphinscheduler/shared_invite/zt-omtdhuio-_JISsxYhiVsltmC5h38yfw) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] huangchenguang123 commented on issue #10049: [BUG] [Plugin] Conditions Task branch flow failed
Posted by GitBox <gi...@apache.org>.
huangchenguang123 commented on issue #10049:
URL: https://github.com/apache/dolphinscheduler/issues/10049#issuecomment-1129475876
> @huangchenguang123 This is the dependent task node. Not condition task node.
This is condition task node. May be you can try?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] huangchenguang123 commented on issue #10049: [BUG] [Plugin] Conditions Task branch flow failed
Posted by GitBox <gi...@apache.org>.
huangchenguang123 commented on issue #10049:
URL: https://github.com/apache/dolphinscheduler/issues/10049#issuecomment-1129509123
The ui that confuses me is one of the problems. Another problems is Custom Parameters' effect. If you only use previousNodes result, where does the custom parameter take effect? I think they will be skip in #10077 because of they be remove from runTask.And If custom parameter will effect, how does it relate to the previousNodes result?This is how task nodes differ from other nodes, because task node need know previousNodes result, and other task's previousNodes only decide when to run next node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10049: [BUG] [Plugin] Conditions Task branch flow failed
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10049:
URL: https://github.com/apache/dolphinscheduler/issues/10049#issuecomment-1128979634
> > I will fix it.
>
> Conditions should use previousNodes result, and now only use dependency result? I find add Custom Parameters can make it trigger fail Node....May be #10077 should use previousNodes and/or Custom Parameters? This is my doubt, don't mind if I'm wrong.
Yes. In this PR, I change the detection logic to use previousNodes to check condition instead of use dependency result.
However, I don't think the success or failure of task nodes should be related to user-defined parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10049: [BUG] [Plugin] Conditions Task branch flow failed
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10049:
URL: https://github.com/apache/dolphinscheduler/issues/10049#issuecomment-1129480895
> > @huangchenguang123 This is the dependent task node. Not condition task node.
>
> This is condition task node. May be you can try?
I take a deep look into UI. There are indeed some misleading description of UI. I'll fix it too. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10049: [BUG] [Plugin] Conditions Task branch flow failed
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10049:
URL: https://github.com/apache/dolphinscheduler/issues/10049#issuecomment-1129473780
@huangchenguang123 This is the dependent task node. Not condition task node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10049: [BUG] [Plugin] Conditions Task branch flow failed
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10049:
URL: https://github.com/apache/dolphinscheduler/issues/10049#issuecomment-1129515757
> The ui that confuses me is one of the problems. Another problems is Custom Parameters' effect. If you only use previousNodes result, where does the custom parameter take effect? I think they will be skip in #10077 because of they be remove from runTask.And If custom parameter will effect, how does it relate to the previousNodes result?This is how task nodes differ from other nodes, because task node need know previousNodes result, and other task's previousNodes only decide when to run next node.
You can retry the condition task node after #10077 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org