You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2023/11/10 15:36:58 UTC
[PR] GH-38670: [Release] Add missing `r/pkgdown/assets/versions.html` to update versions [arrow]
raulcd opened a new pull request, #38671:
URL: https://github.com/apache/arrow/pull/38671
### Rationale for this change
File is missing when bumping versions.
### What changes are included in this PR?
Add the file to the git add commands.
### Are these changes tested?
Locally on the bump-versions.
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38670: [Release] Add missing `r/pkgdown/assets/versions.html` to update versions [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #38671:
URL: https://github.com/apache/arrow/pull/38671#issuecomment-1851760579
> @assignUser @paleolimbot as discussed I've removed the file as it seems not used.
The file is not needed in the repo; it's just needed for the website, as long as it has the correct versions here: https://arrow.apache.org/docs/r/versions.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38670: [Release] Add missing `r/pkgdown/assets/versions.html` to update versions [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #38671:
URL: https://github.com/apache/arrow/pull/38671#discussion_r1390473762
##########
r/pkgdown/assets/versions.html:
##########
@@ -1,9 +1,11 @@
<!DOCTYPE html>
<html>
-<body><p><a href="../dev/r/">13.0.0.9000 (dev)</a></p>
-<p><a href="../r/">13.0.0.1 (release)</a></p>
+<body><p><a href="../dev/r/">14.0.0.9000 (dev)</a></p>
+<p><a href="../r/">14.0.0 (release)</a></p>
+<p><a href="../13.0/r/">13.0.0.1</a></p>
<p><a href="../12.0/r/">12.0.1.1</a></p>
-<p><a href="../11.0/r/">11.0.0.3</a></p>
+<p><a href="../12.0/r/">12.0.0</a></p>
Review Comment:
Should we remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38670: [Release] Add missing `r/pkgdown/assets/versions.html` to update versions [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #38671:
URL: https://github.com/apache/arrow/pull/38671#discussion_r1416086393
##########
r/pkgdown/assets/versions.html:
##########
@@ -1,9 +1,11 @@
<!DOCTYPE html>
<html>
-<body><p><a href="../dev/r/">13.0.0.9000 (dev)</a></p>
-<p><a href="../r/">13.0.0.1 (release)</a></p>
+<body><p><a href="../dev/r/">14.0.0.9000 (dev)</a></p>
+<p><a href="../r/">14.0.0 (release)</a></p>
+<p><a href="../13.0/r/">13.0.0.1</a></p>
<p><a href="../12.0/r/">12.0.1.1</a></p>
-<p><a href="../11.0/r/">11.0.0.3</a></p>
+<p><a href="../12.0/r/">12.0.0</a></p>
Review Comment:
I'm not familiar with the doc setup so :shrug: sorry^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38670: [Release] Add missing `r/pkgdown/assets/versions.html` to update versions [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #38671:
URL: https://github.com/apache/arrow/pull/38671#discussion_r1391296427
##########
r/pkgdown/assets/versions.html:
##########
@@ -1,9 +1,11 @@
<!DOCTYPE html>
<html>
-<body><p><a href="../dev/r/">13.0.0.9000 (dev)</a></p>
-<p><a href="../r/">13.0.0.1 (release)</a></p>
+<body><p><a href="../dev/r/">14.0.0.9000 (dev)</a></p>
+<p><a href="../r/">14.0.0 (release)</a></p>
+<p><a href="../13.0/r/">13.0.0.1</a></p>
<p><a href="../12.0/r/">12.0.1.1</a></p>
-<p><a href="../11.0/r/">11.0.0.3</a></p>
+<p><a href="../12.0/r/">12.0.0</a></p>
Review Comment:
This is part of the automated diff generated when `post-11-bump-versions.sh` is run. I also found that strange but might mean there is something wrong when bumping the versions.
@thisisnic @paleolimbot @assignUser is there anything we should fix when automatically bumping versions on the `versions.html` file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38670: [Release] Add missing `r/pkgdown/assets/versions.html` to update versions [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #38671:
URL: https://github.com/apache/arrow/pull/38671#issuecomment-1827262985
@assignUser @paleolimbot as discussed I've removed the file as it seems not used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38670: [Release] Add missing `r/pkgdown/assets/versions.html` to update versions [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic closed pull request #38671: GH-38670: [Release] Add missing `r/pkgdown/assets/versions.html` to update versions
URL: https://github.com/apache/arrow/pull/38671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38670: [Release] Add missing `r/pkgdown/assets/versions.html` to update versions [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #38671:
URL: https://github.com/apache/arrow/pull/38671#issuecomment-2040843399
I think the comments above mean that this PR is no longer needed so I'm closing this, but if I'm wrong let me know and we can reopen and merge this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38670: [Release] Add missing `r/pkgdown/assets/versions.html` to update versions [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #38671:
URL: https://github.com/apache/arrow/pull/38671#issuecomment-1827636123
I reverted the last change because I thought the R failures could be related but they don't seem to be as they are failing without removing the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org