[GitHub] csantanapr opened a new issue #96: problems with error handling

[GitBox <gi...@apache.org>]

csantanapr opened a new issue #96: problems with error handling
URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/issues/96
 
 
   The recent PR #95
   cause problems in the travis pipeline in core repo: https://travis-ci.org/apache/incubator-openwhisk/builds/447588143
   
   The user should be allowed to on Error return an error object or simple value, that's the contract today
   The PR changes this to always make it a string `{ error: <String>}`
   
   Another problem I see this PR always do a console.error() if it contains error.message, this is not ideal as it can leak privacy data into logs, and in some production system eat over their quota.
   The user should be in control on what to log or not. we should not force the console.error
   
   I understand that the PR was trying to address #63 I think the real problem is that error native objects were not being serialize. 
   
   I propose:
   1. Do not change the current contract on not constraining the output of the Function to a string.
   2. Handle properly Event type errors object that it serializes and is not empty
   3. Do not console.error, this is user land responsibility domain on what they want to log or not.
     

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services