You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ian Duffy <ia...@ianduffy.ie> on 2013/07/30 19:06:51 UTC

Review Request 13065: Add support for memberof filter i.e. groups within LDAP.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13065/
-----------------------------------------------------------

Review request for cloudstack and Abhinandan Prateek.


Repository: cloudstack-git


Description
-------

Add support for memberof filter i.e. groups within LDAP.


Diffs
-----

  plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java d0ae4d2 
  plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java f255752 
  server/src/com/cloud/configuration/Config.java 1ec0576 
  setup/db/db/schema-410to420.sql f4cd1b1 

Diff: https://reviews.apache.org/r/13065/diff/


Testing
-------

Tested against active directory, worked successfully.

If the value is left empty its not applied.


Thanks,

Ian Duffy


Re: Review Request 13065: Add support for memberof filter i.e. groups within LDAP.

Posted by Ian Duffy <ia...@ianduffy.ie>.

> On July 30, 2013, 5:30 p.m., Jenkins Cloudstack.org wrote:
> > Review 13065 failed the build test : FAILURE
> > The url of build cloudstack-master-with-patch #87 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/87/

Please note jenkins attempted to apply this to the master branch and not the ldapplugin branch resulting in a fail.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13065/#review24255
-----------------------------------------------------------


On July 30, 2013, 5:06 p.m., Ian Duffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13065/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 5:06 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Add support for memberof filter i.e. groups within LDAP.
> 
> 
> Diffs
> -----
> 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java d0ae4d2 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java f255752 
>   server/src/com/cloud/configuration/Config.java 1ec0576 
>   setup/db/db/schema-410to420.sql f4cd1b1 
> 
> Diff: https://reviews.apache.org/r/13065/diff/
> 
> 
> Testing
> -------
> 
> Tested against active directory, worked successfully.
> 
> If the value is left empty its not applied.
> 
> 
> Thanks,
> 
> Ian Duffy
> 
>


Re: Review Request 13065: Add support for memberof filter i.e. groups within LDAP.

Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13065/#review24255
-----------------------------------------------------------


Review 13065 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #87 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/87/

- Jenkins Cloudstack.org


On July 30, 2013, 5:06 p.m., Ian Duffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13065/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 5:06 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Add support for memberof filter i.e. groups within LDAP.
> 
> 
> Diffs
> -----
> 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java d0ae4d2 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java f255752 
>   server/src/com/cloud/configuration/Config.java 1ec0576 
>   setup/db/db/schema-410to420.sql f4cd1b1 
> 
> Diff: https://reviews.apache.org/r/13065/diff/
> 
> 
> Testing
> -------
> 
> Tested against active directory, worked successfully.
> 
> If the value is left empty its not applied.
> 
> 
> Thanks,
> 
> Ian Duffy
> 
>