You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/11 06:03:05 UTC
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #412: Delete VM show specific data disks
davidjumani opened a new pull request #412:
URL: https://github.com/apache/cloudstack-primate/pull/412
Fixes #389
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #412: Delete VM show specific data disks
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #412:
URL: https://github.com/apache/cloudstack-primate/pull/412#issuecomment-643059554
@rhtyd Good to go!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #412: Delete VM show specific data disks
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #412:
URL: https://github.com/apache/cloudstack-primate/pull/412
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #412: Delete VM show specific data disks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #412:
URL: https://github.com/apache/cloudstack-primate/pull/412#issuecomment-643061491
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/412 (JID-1991)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #412: Delete VM show specific data disks
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #412:
URL: https://github.com/apache/cloudstack-primate/pull/412#discussion_r439225807
##########
File path: src/config/section/compute.js
##########
@@ -334,6 +334,12 @@ export default {
icon: 'delete',
label: 'label.action.destroy.instance',
args: ['expunge', 'volumeids'],
+ mapping: {
+ volumeids: {
+ api: 'listVolumes',
+ params: (record) => { return { virtualmachineid: record.id } }
Review comment:
Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #412: Delete VM show specific data disks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #412:
URL: https://github.com/apache/cloudstack-primate/pull/412#issuecomment-643546938
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #412: Delete VM show specific data disks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #412:
URL: https://github.com/apache/cloudstack-primate/pull/412#issuecomment-643059627
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #412: Delete VM show specific data disks
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #412:
URL: https://github.com/apache/cloudstack-primate/pull/412#issuecomment-643059298
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #412: Delete VM show specific data disks
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #412:
URL: https://github.com/apache/cloudstack-primate/pull/412#issuecomment-643070565
@davidjumani half-lgtm, when you do test please do a thorough testing against the feature in old UI. By default the root disk will get expunged the feature is for data disk as seen in the old UI form:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #412: Delete VM show specific data disks
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #412:
URL: https://github.com/apache/cloudstack-primate/pull/412#issuecomment-643546885
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #412: Delete VM show specific data disks
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #412:
URL: https://github.com/apache/cloudstack-primate/pull/412#discussion_r439211590
##########
File path: src/config/section/compute.js
##########
@@ -334,6 +334,12 @@ export default {
icon: 'delete',
label: 'label.action.destroy.instance',
args: ['expunge', 'volumeids'],
+ mapping: {
+ volumeids: {
+ api: 'listVolumes',
+ params: (record) => { return { virtualmachineid: record.id } }
Review comment:
Pass a type=DATADISK (check the params), that should address the issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org