You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by tr...@locus.apache.org on 2000/06/03 16:31:36 UTC

cvs commit: apache-2.0/src CHANGES

trawick     00/06/03 07:31:36

  Modified:    src/modules/standard mod_cgi.c
               src      CHANGES
  Log:
  mod_cgi: Make ScriptLog directive work again by fixing the
  flags passed to ap_open().
  
  TODO: Roll recent mod_cgi logging changes into mod_cgid.
  
  Revision  Changes    Path
  1.44      +2 -2      apache-2.0/src/modules/standard/mod_cgi.c
  
  Index: mod_cgi.c
  ===================================================================
  RCS file: /home/cvs/apache-2.0/src/modules/standard/mod_cgi.c,v
  retrieving revision 1.43
  retrieving revision 1.44
  diff -u -r1.43 -r1.44
  --- mod_cgi.c	2000/05/28 11:48:24	1.43
  +++ mod_cgi.c	2000/06/03 14:31:34	1.44
  @@ -185,7 +185,7 @@
           ((ap_stat(&finfo, ap_server_root_relative(r->pool, conf->logname), r->pool) == APR_SUCCESS)
            &&  (finfo.size > conf->logbytes)) ||
             (ap_open(&f, ap_server_root_relative(r->pool, conf->logname),
  -                   APR_APPEND, APR_OS_DEFAULT, r->pool) != APR_SUCCESS)) {
  +                   APR_APPEND|APR_WRITE|APR_CREATE, APR_OS_DEFAULT, r->pool) != APR_SUCCESS)) {
   	return ret;
       }
   
  @@ -234,7 +234,7 @@
           ((ap_stat(&finfo, ap_server_root_relative(r->pool, conf->logname), r->pool) == APR_SUCCESS)
            &&  (finfo.size > conf->logbytes)) ||
            (ap_open(&f, ap_server_root_relative(r->pool, conf->logname),
  -                  APR_APPEND, APR_OS_DEFAULT, r->pool) != APR_SUCCESS)) {
  +                  APR_APPEND|APR_WRITE|APR_CREATE, APR_OS_DEFAULT, r->pool) != APR_SUCCESS)) {
   	/* Soak up script output */
   	while (ap_bgets(argsbuffer, HUGE_STRING_LEN, script_in) > 0)
   	    continue;
  
  
  
  1.129     +2 -0      apache-2.0/src/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /home/cvs/apache-2.0/src/CHANGES,v
  retrieving revision 1.128
  retrieving revision 1.129
  diff -u -r1.128 -r1.129
  --- CHANGES	2000/06/02 15:33:13	1.128
  +++ CHANGES	2000/06/03 14:31:35	1.129
  @@ -1,5 +1,7 @@
   Changes with Apache 2.0a4
   
  +  *) mod_cgi: Make ScriptLog directive work again.  [Jeff Trawick]
  +
     *) Add pre-config hooks back to all modules.
        [Ryan Bloom]