You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/08/05 23:30:33 UTC
[GitHub] [activemq-artemis] michaelandrepearce opened a new pull request #3237: [ARTEMIS-2873] Ensure configuation managed queues are not auto delete…
michaelandrepearce opened a new pull request #3237:
URL: https://github.com/apache/activemq-artemis/pull/3237
…d these should only be removed if removed in configuration.
Auto Delete Queues and Auto Delete Created Queues should only apply to NON configuration managed queues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on pull request #3237: [ARTEMIS-2873] Ensure configuation managed queues are not auto delete…
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on pull request #3237:
URL: https://github.com/apache/activemq-artemis/pull/3237#issuecomment-670162991
@jbertram good catch, i missed a local change in the test case, i forgot to commit, queueConfigurationManaged was under wrong address, so didnt pick up the address settings. Should be failing without the change and passing with.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3237: [ARTEMIS-2873] Ensure configuation managed queues are not auto delete…
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3237:
URL: https://github.com/apache/activemq-artemis/pull/3237#issuecomment-670162991
@jbertram good catch, i missed a local change, i forgot to commit, queueConfigurationManaged was under wrong address, so didnt pick up the address settings. Should be failing without the change and passing with.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3237: [ARTEMIS-2873] Ensure configuation managed queues are not auto delete…
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3237:
URL: https://github.com/apache/activemq-artemis/pull/3237#issuecomment-669994382
I was going to merge this, but the test succeeds even without the fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3237: [ARTEMIS-2873] Ensure configuation managed queues are not auto delete…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3237:
URL: https://github.com/apache/activemq-artemis/pull/3237
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org