You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "mingleizhang (JIRA)" <ji...@apache.org> on 2017/04/24 01:50:04 UTC

[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

    [ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980624#comment-15980624 ] 

mingleizhang commented on FLINK-5855:
-------------------------------------

[~tedyu] Hi, Ted. I would ask if {code}pendingFilesPerCheckpoint {code}  prior to the call of {code}handlePendingFilesForPreviousCheckpoints{code}. It is a maybe that the it has alreay removed all elements from the map. Then trigger the {code}handlePendingFilesForPreviousCheckpoints{code}. Is there a problem should occur here ?  CC [~till.rohrmann]

> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
> ----------------------------------------------------------------
>
>                 Key: FLINK-5855
>                 URL: https://issues.apache.org/jira/browse/FLINK-5855
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming Connectors
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}    handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
>     synchronized (restoredState.pendingFilesPerCheckpoint) {
>       restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to handlePendingFilesForPreviousCheckpoints().



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)