You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Arun C Murthy (JIRA)" <ji...@apache.org> on 2008/01/07 05:02:34 UTC
[jira] Created: (HADOOP-2535) Indentation fix in TaskRunner.java
Indentation fix in TaskRunner.java
----------------------------------
Key: HADOOP-2535
URL: https://issues.apache.org/jira/browse/HADOOP-2535
Project: Hadoop
Issue Type: Bug
Components: mapred
Affects Versions: 0.15.2
Reporter: Arun C Murthy
Assignee: Arun C Murthy
Priority: Trivial
Fix For: 0.16.0
TaskRunner.java (289-344) have wrong indentation - 4 spaces rather than the standard 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2535) Remove support for deprecated
mapred.child.heap.size and indentation fix in TaskRunner.java
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-2535:
----------------------------------
Status: Patch Available (was: Open)
> Remove support for deprecated mapred.child.heap.size and indentation fix in TaskRunner.java
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-2535
> URL: https://issues.apache.org/jira/browse/HADOOP-2535
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.15.2
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: HADOOP-2535_0_20080107.patch, HADOOP-2535_1_20080107.patch, HADOOP-2535_2_20080107.patch
>
>
> TaskRunner.java (289-344) have wrong indentation - 4 spaces rather than the standard 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2535) Indentation fix in TaskRunner.java
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556474#action_12556474 ]
Arun C Murthy commented on HADOOP-2535:
---------------------------------------
I propose to use this same jira to remove support for the deprecated {{mapred.child.heap.size}} parameter. It was superceded by {{mapred.child.java.opts}} long ago...
> Indentation fix in TaskRunner.java
> ----------------------------------
>
> Key: HADOOP-2535
> URL: https://issues.apache.org/jira/browse/HADOOP-2535
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.15.2
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Priority: Trivial
> Fix For: 0.16.0
>
>
> TaskRunner.java (289-344) have wrong indentation - 4 spaces rather than the standard 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2535) Remove support for deprecated
mapred.child.heap.size and indentation fix in TaskRunner.java
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-2535:
----------------------------------
Status: Patch Available (was: Open)
> Remove support for deprecated mapred.child.heap.size and indentation fix in TaskRunner.java
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-2535
> URL: https://issues.apache.org/jira/browse/HADOOP-2535
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.15.2
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: HADOOP-2535_0_20080107.patch
>
>
> TaskRunner.java (289-344) have wrong indentation - 4 spaces rather than the standard 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2535) Remove support for deprecated
mapred.child.heap.size and indentation fix in TaskRunner.java
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-2535:
----------------------------------
Status: Open (was: Patch Available)
I noticed, a little too late, that another old comment is _wrong_ ... *smile*
> Remove support for deprecated mapred.child.heap.size and indentation fix in TaskRunner.java
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-2535
> URL: https://issues.apache.org/jira/browse/HADOOP-2535
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.15.2
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: HADOOP-2535_0_20080107.patch
>
>
> TaskRunner.java (289-344) have wrong indentation - 4 spaces rather than the standard 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2535) Remove support for deprecated
mapred.child.heap.size and indentation fix in TaskRunner.java
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-2535:
----------------------------------
Status: Open (was: Patch Available)
I need to fix some more docs for {{mapred.child.heap.size}} ...
> Remove support for deprecated mapred.child.heap.size and indentation fix in TaskRunner.java
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-2535
> URL: https://issues.apache.org/jira/browse/HADOOP-2535
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.15.2
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: HADOOP-2535_0_20080107.patch, HADOOP-2535_1_20080107.patch
>
>
> TaskRunner.java (289-344) have wrong indentation - 4 spaces rather than the standard 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2535) Remove support for deprecated
mapred.child.heap.size and indentation fix in TaskRunner.java
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556534#action_12556534 ]
Devaraj Das commented on HADOOP-2535:
-------------------------------------
+1
> Remove support for deprecated mapred.child.heap.size and indentation fix in TaskRunner.java
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-2535
> URL: https://issues.apache.org/jira/browse/HADOOP-2535
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.15.2
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: HADOOP-2535_0_20080107.patch, HADOOP-2535_1_20080107.patch, HADOOP-2535_2_20080107.patch
>
>
> TaskRunner.java (289-344) have wrong indentation - 4 spaces rather than the standard 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2535) Remove support for deprecated
mapred.child.heap.size and indentation fix in TaskRunner.java
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-2535:
----------------------------------
Priority: Minor (was: Trivial)
Summary: Remove support for deprecated mapred.child.heap.size and indentation fix in TaskRunner.java (was: Indentation fix in TaskRunner.java)
> Remove support for deprecated mapred.child.heap.size and indentation fix in TaskRunner.java
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-2535
> URL: https://issues.apache.org/jira/browse/HADOOP-2535
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.15.2
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Priority: Minor
> Fix For: 0.16.0
>
>
> TaskRunner.java (289-344) have wrong indentation - 4 spaces rather than the standard 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2535) Remove support for deprecated
mapred.child.heap.size and indentation fix in TaskRunner.java
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-2535:
----------------------------------
Attachment: HADOOP-2535_1_20080107.patch
Updated patch to fix:
{noformat}
- // <name>mapred.child.optional.jvm.args</name>
{noformat}
as
{noformat}
- // <name>mapred.child.java.opts</name>
{noformat}
> Remove support for deprecated mapred.child.heap.size and indentation fix in TaskRunner.java
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-2535
> URL: https://issues.apache.org/jira/browse/HADOOP-2535
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.15.2
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: HADOOP-2535_0_20080107.patch, HADOOP-2535_1_20080107.patch
>
>
> TaskRunner.java (289-344) have wrong indentation - 4 spaces rather than the standard 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2535) Remove support for deprecated
mapred.child.heap.size and indentation fix in TaskRunner.java
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-2535:
----------------------------------
Attachment: HADOOP-2535_0_20080107.patch
Candidate patch which removes support for deprecated {{mapred.child.heap.size}} and fixes the indentation irritants. I've also updated some comments...
> Remove support for deprecated mapred.child.heap.size and indentation fix in TaskRunner.java
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-2535
> URL: https://issues.apache.org/jira/browse/HADOOP-2535
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.15.2
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: HADOOP-2535_0_20080107.patch
>
>
> TaskRunner.java (289-344) have wrong indentation - 4 spaces rather than the standard 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2535) Remove support for deprecated
mapred.child.heap.size and indentation fix in TaskRunner.java
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-2535:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this.
> Remove support for deprecated mapred.child.heap.size and indentation fix in TaskRunner.java
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-2535
> URL: https://issues.apache.org/jira/browse/HADOOP-2535
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.15.2
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: HADOOP-2535_0_20080107.patch, HADOOP-2535_1_20080107.patch, HADOOP-2535_2_20080107.patch
>
>
> TaskRunner.java (289-344) have wrong indentation - 4 spaces rather than the standard 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2535) Remove support for deprecated
mapred.child.heap.size and indentation fix in TaskRunner.java
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-2535:
----------------------------------
Status: Patch Available (was: Open)
> Remove support for deprecated mapred.child.heap.size and indentation fix in TaskRunner.java
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-2535
> URL: https://issues.apache.org/jira/browse/HADOOP-2535
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.15.2
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: HADOOP-2535_0_20080107.patch, HADOOP-2535_1_20080107.patch
>
>
> TaskRunner.java (289-344) have wrong indentation - 4 spaces rather than the standard 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2535) Remove support for deprecated
mapred.child.heap.size and indentation fix in TaskRunner.java
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556647#action_12556647 ]
Hadoop QA commented on HADOOP-2535:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12372607/HADOOP-2535_2_20080107.patch
against trunk revision .
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1502/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1502/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1502/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1502/console
This message is automatically generated.
> Remove support for deprecated mapred.child.heap.size and indentation fix in TaskRunner.java
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-2535
> URL: https://issues.apache.org/jira/browse/HADOOP-2535
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.15.2
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: HADOOP-2535_0_20080107.patch, HADOOP-2535_1_20080107.patch, HADOOP-2535_2_20080107.patch
>
>
> TaskRunner.java (289-344) have wrong indentation - 4 spaces rather than the standard 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2535) Remove support for deprecated
mapred.child.heap.size and indentation fix in TaskRunner.java
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-2535:
----------------------------------
Attachment: HADOOP-2535_2_20080107.patch
Another shot, fixed {{conf/hadoop-default.xml}} to reflect removal of {{mapred.child.heap.size}} too.
> Remove support for deprecated mapred.child.heap.size and indentation fix in TaskRunner.java
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-2535
> URL: https://issues.apache.org/jira/browse/HADOOP-2535
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.15.2
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: HADOOP-2535_0_20080107.patch, HADOOP-2535_1_20080107.patch, HADOOP-2535_2_20080107.patch
>
>
> TaskRunner.java (289-344) have wrong indentation - 4 spaces rather than the standard 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.