You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhangstar333 (via GitHub)" <gi...@apache.org> on 2025/04/16 13:23:56 UTC
[PR] window funnel [doris]
zhangstar333 opened a new pull request, #50109:
URL: https://github.com/apache/doris/pull/50109
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2813147279
<details>
<summary>TPC-DS: <b>Total hot run time: 185785 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 913a686bf5c17026e4848132ed6cd2654797f8af, data reload: false
query1 1004 468 498 468
query2 6570 1801 1782 1782
query3 6769 216 218 216
query4 26429 23633 23542 23542
query5 4358 624 459 459
query6 313 216 190 190
query7 4629 487 289 289
query8 309 246 242 242
query9 8637 2534 2568 2534
query10 475 319 259 259
query11 15535 15062 14791 14791
query12 160 112 105 105
query13 1669 521 390 390
query14 8758 6081 6097 6081
query15 204 190 179 179
query16 7136 658 447 447
query17 1206 716 571 571
query18 1976 418 307 307
query19 201 196 156 156
query20 128 123 119 119
query21 211 130 105 105
query22 4166 4161 4115 4115
query23 33755 33030 33255 33030
query24 8451 2358 2356 2356
query25 543 446 397 397
query26 1236 277 148 148
query27 2759 492 328 328
query28 4371 2098 2076 2076
query29 779 556 429 429
query30 282 213 187 187
query31 903 847 773 773
query32 71 63 66 63
query33 562 409 299 299
query34 778 842 504 504
query35 793 837 752 752
query36 952 967 861 861
query37 125 97 80 80
query38 4134 4201 4026 4026
query39 1450 1407 1392 1392
query40 212 114 103 103
query41 56 53 52 52
query42 118 104 104 104
query43 483 517 463 463
query44 1261 796 792 792
query45 182 180 168 168
query46 818 1001 622 622
query47 1725 1769 1698 1698
query48 369 415 289 289
query49 785 517 424 424
query50 619 691 391 391
query51 4157 4144 4144 4144
query52 108 109 103 103
query53 225 252 183 183
query54 568 570 500 500
query55 80 82 83 82
query56 306 284 283 283
query57 1149 1148 1074 1074
query58 265 251 255 251
query59 2478 2604 2604 2604
query60 333 307 293 293
query61 136 128 121 121
query62 781 711 697 697
query63 236 181 182 181
query64 4366 1007 709 709
query65 4347 4263 4251 4251
query66 1149 408 336 336
query67 15655 15479 15169 15169
query68 8636 879 516 516
query69 472 300 269 269
query70 1221 1115 1139 1115
query71 475 334 285 285
query72 5231 4635 4633 4633
query73 706 637 340 340
query74 8878 9103 8967 8967
query75 4118 3198 2707 2707
query76 3628 1190 744 744
query77 777 377 288 288
query78 10014 10154 9300 9300
query79 2074 876 571 571
query80 754 498 448 448
query81 466 259 217 217
query82 429 131 96 96
query83 281 244 238 238
query84 294 113 81 81
query85 775 359 316 316
query86 342 311 289 289
query87 4422 4411 4350 4350
query88 3390 2215 2229 2215
query89 395 307 282 282
query90 1930 206 236 206
query91 139 139 110 110
query92 75 60 57 57
query93 1538 910 566 566
query94 670 403 300 300
query95 373 294 280 280
query96 488 558 273 273
query97 3154 3221 3144 3144
query98 219 211 207 207
query99 1412 1398 1240 1240
Total cold run time: 273530 ms
Total hot run time: 185785 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2813409782
# BE UT Coverage Report
Increment line coverage `76.47% (78/102)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/913a686bf5c17026e4848132ed6cd2654797f8af_913a686bf5c17026e4848132ed6cd2654797f8af/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/913a686bf5c17026e4848132ed6cd2654797f8af_913a686bf5c17026e4848132ed6cd2654797f8af/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.15% (14425/27141) |
| Line Coverage | 42.00% (124935/297466) |
| Region Coverage | 40.82% (63834/156383) |
| Branch Coverage | 35.46% (32104/90540) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2815140762
<details>
<summary>TPC-H: <b>Total hot run time: 34043 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 942f1dfa72f3d02cc78f0beff602f0381d9fa3b0, data reload: false
------ Round 1 ----------------------------------
q1 26169 5148 5039 5039
q2 2083 290 193 193
q3 10499 1274 705 705
q4 10283 1025 545 545
q5 8809 2440 2368 2368
q6 187 167 137 137
q7 923 743 617 617
q8 9329 1277 1037 1037
q9 7480 5126 5196 5126
q10 6818 2316 1887 1887
q11 478 288 266 266
q12 349 352 216 216
q13 17775 3725 3081 3081
q14 231 220 206 206
q15 526 480 482 480
q16 447 454 398 398
q17 592 869 366 366
q18 7728 7297 7163 7163
q19 1236 957 578 578
q20 338 333 220 220
q21 3936 2678 2438 2438
q22 1066 1037 977 977
Total cold run time: 117282 ms
Total hot run time: 34043 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5148 5075 5498 5075
q2 244 333 229 229
q3 2118 2637 2263 2263
q4 1416 1861 1554 1554
q5 4531 4490 4385 4385
q6 215 176 127 127
q7 1975 1870 1714 1714
q8 2605 2490 2613 2490
q9 7110 7147 7163 7147
q10 2983 3190 2790 2790
q11 584 522 502 502
q12 680 798 604 604
q13 3456 3839 3278 3278
q14 294 285 285 285
q15 530 498 466 466
q16 458 499 460 460
q17 1151 1541 1415 1415
q18 7939 7439 7366 7366
q19 808 828 910 828
q20 2004 2038 1897 1897
q21 5390 4729 4559 4559
q22 1074 1039 981 981
Total cold run time: 52713 ms
Total hot run time: 50415 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2815106209
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2815449299
<details>
<summary>TPC-H: <b>Total hot run time: 33732 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b3d8d06c2302d59a89e710c6071e1938540f55e3, data reload: false
------ Round 1 ----------------------------------
q1 26116 5092 5010 5010
q2 2065 274 181 181
q3 10393 1185 694 694
q4 10243 980 538 538
q5 7564 2376 2293 2293
q6 187 161 133 133
q7 907 817 601 601
q8 9311 1246 1102 1102
q9 6845 5096 5065 5065
q10 6852 2294 1905 1905
q11 496 283 271 271
q12 346 350 214 214
q13 17797 3672 3081 3081
q14 232 227 213 213
q15 529 494 490 490
q16 446 446 392 392
q17 584 845 352 352
q18 7543 7298 7067 7067
q19 1361 946 539 539
q20 325 327 214 214
q21 3867 2617 2413 2413
q22 978 997 964 964
Total cold run time: 114987 ms
Total hot run time: 33732 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5415 5070 5076 5070
q2 239 333 231 231
q3 2116 2604 2256 2256
q4 1393 1822 1365 1365
q5 4368 4370 4375 4370
q6 228 174 125 125
q7 1984 1919 1733 1733
q8 2574 2557 2832 2557
q9 7273 7274 6999 6999
q10 3030 3177 2737 2737
q11 591 509 487 487
q12 663 795 599 599
q13 3502 3942 3322 3322
q14 282 318 300 300
q15 535 476 481 476
q16 464 495 465 465
q17 1138 1548 1366 1366
q18 7703 7713 7342 7342
q19 769 832 1013 832
q20 2002 1982 1806 1806
q21 5117 4793 4748 4748
q22 1122 1067 1003 1003
Total cold run time: 52508 ms
Total hot run time: 50189 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2814591306
<details>
<summary>ClickBench: <b>Total hot run time: 29.4 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 93d3e7f70e7ea67e31d2ecc64e7e975847d4f0b7, data reload: false
query1 0.04 0.04 0.03
query2 0.11 0.10 0.11
query3 0.27 0.19 0.19
query4 1.59 0.19 0.19
query5 0.59 0.58 0.59
query6 1.17 0.71 0.71
query7 0.02 0.02 0.01
query8 0.05 0.04 0.03
query9 0.56 0.53 0.52
query10 0.55 0.57 0.56
query11 0.15 0.11 0.10
query12 0.15 0.12 0.11
query13 0.63 0.59 0.61
query14 1.13 1.22 1.18
query15 0.89 0.85 0.85
query16 0.38 0.36 0.38
query17 1.01 1.01 1.02
query18 0.20 0.20 0.19
query19 1.87 1.73 1.81
query20 0.02 0.01 0.02
query21 15.40 0.87 0.56
query22 0.76 1.23 0.70
query23 14.86 1.40 0.68
query24 6.67 2.44 0.69
query25 0.54 0.23 0.12
query26 0.55 0.17 0.15
query27 0.05 0.05 0.05
query28 9.59 0.81 0.43
query29 12.52 3.97 3.28
query30 0.25 0.08 0.06
query31 2.82 0.57 0.38
query32 3.23 0.55 0.47
query33 2.99 2.99 3.03
query34 15.72 5.10 4.50
query35 4.52 4.51 4.48
query36 0.67 0.50 0.48
query37 0.08 0.06 0.06
query38 0.05 0.03 0.04
query39 0.04 0.03 0.03
query40 0.15 0.13 0.14
query41 0.08 0.03 0.03
query42 0.04 0.03 0.02
query43 0.04 0.04 0.03
Total cold run time: 103 s
Total hot run time: 29.4 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #50109:
URL: https://github.com/apache/doris/pull/50109#discussion_r2050543018
##########
be/src/vec/aggregate_functions/aggregate_function_window_funnel.h:
##########
@@ -85,71 +111,54 @@ struct WindowFunnelState {
int64_t window;
bool enable_mode;
WindowFunnelMode window_funnel_mode;
- mutable vectorized::MutableBlock mutable_block;
- ColumnVector<NativeType>::Container* timestamp_column_data = nullptr;
- std::vector<ColumnVector<UInt8>::Container*> event_columns_datas;
- SortDescription sort_description {1};
+ DataValue events_list;
WindowFunnelState() {
event_count = 0;
window = 0;
window_funnel_mode = WindowFunnelMode::INVALID;
-
- sort_description[0].column_number = 0;
- sort_description[0].direction = 1;
- sort_description[0].nulls_direction = -1;
}
WindowFunnelState(int arg_event_count) : WindowFunnelState() {
event_count = arg_event_count;
- event_columns_datas.resize(event_count);
- auto timestamp_column = ColumnVector<NativeType>::create();
-
- MutableColumns event_columns;
- for (int i = 0; i < event_count; i++) {
- event_columns.emplace_back(ColumnVector<UInt8>::create());
- }
- Block tmp_block;
- tmp_block.insert({std::move(timestamp_column),
- DataTypeFactory::instance().create_data_type(TYPE_INDEX), "timestamp"});
- for (int i = 0; i < event_count; i++) {
- tmp_block.insert({std::move(event_columns[i]),
- DataTypeFactory::instance().create_data_type(TypeIndex::UInt8),
- "event_" + std::to_string(i)});
- }
-
- mutable_block = MutableBlock(std::move(tmp_block));
- _reset_columns_ptr();
+ events_list.event_columns_data.resize(event_count);
}
- void _reset_columns_ptr() {
- auto& ts_column = mutable_block.get_column_by_position(0);
- timestamp_column_data = &assert_cast<ColumnVector<NativeType>&>(*ts_column).get_data();
- for (int i = 0; i != event_count; i++) {
- auto& event_column = mutable_block.get_column_by_position(i + 1);
- event_columns_datas[i] = &assert_cast<ColumnVector<UInt8>&>(*event_column).get_data();
- }
- }
- void reset() { mutable_block.clear_column_data(); }
+ void reset() { events_list.clear(); }
void add(const IColumn** arg_columns, ssize_t row_num, int64_t win, WindowFunnelMode mode) {
window = win;
window_funnel_mode = enable_mode ? mode : WindowFunnelMode::DEFAULT;
-
- timestamp_column_data->push_back(
+ events_list.dt.emplace_back(
assert_cast<const ColumnVector<NativeType>&>(*arg_columns[2]).get_data()[row_num]);
for (int i = 0; i < event_count; i++) {
- event_columns_datas[i]->push_back(
+ events_list.event_columns_data[i].emplace_back(
assert_cast<const ColumnVector<UInt8>&>(*arg_columns[3 + i])
.get_data()[row_num]);
}
}
void sort() {
- Block tmp_block = mutable_block.to_block();
- auto block = tmp_block.clone_without_columns();
- sort_block(tmp_block, block, sort_description, 0);
- mutable_block = std::move(block);
- _reset_columns_ptr();
+ std::vector<size_t> indices(events_list.size());
+ std::iota(indices.begin(), indices.end(), 0);
+ std::sort(indices.begin(), indices.end(),
+ [this](size_t i1, size_t i2) { return events_list.dt[i1] < events_list.dt[i2]; });
+
+ auto reorder = [&indices](auto& vec) {
+ std::vector<typename std::decay_t<decltype(vec)>::value_type> temp;
+ temp.reserve(indices.size());
+ for (auto idx : indices) {
Review Comment:
std::decay_t<deltype(vec)> temp;
temp.resize()
temp[i] = vec[indices[i]];
std::swap(vec, temp);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2812315539
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2817524278
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] window funnel [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2811565515
<details>
<summary>TPC-H: <b>Total hot run time: 34211 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 69bd89aec16f28942429a32ce48b943d042e85ce, data reload: false
------ Round 1 ----------------------------------
q1 25882 5068 5026 5026
q2 2072 288 184 184
q3 10385 1251 711 711
q4 10226 1040 568 568
q5 7539 2346 2436 2346
q6 185 163 138 138
q7 926 764 621 621
q8 9342 1286 1094 1094
q9 6838 5083 5180 5083
q10 6821 2313 1912 1912
q11 475 292 274 274
q12 361 366 227 227
q13 17804 3683 3147 3147
q14 254 225 214 214
q15 536 487 481 481
q16 452 454 409 409
q17 566 874 364 364
q18 7607 7218 7134 7134
q19 1220 962 576 576
q20 343 345 224 224
q21 4485 3489 2506 2506
q22 1102 1050 972 972
Total cold run time: 115421 ms
Total hot run time: 34211 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5128 5298 5120 5120
q2 246 329 237 237
q3 2149 2677 2286 2286
q4 1439 1845 1468 1468
q5 4519 4459 4401 4401
q6 211 170 127 127
q7 2000 1924 1740 1740
q8 2599 2579 2517 2517
q9 7150 7236 7100 7100
q10 2994 3183 2709 2709
q11 587 508 485 485
q12 688 787 650 650
q13 3459 3858 3325 3325
q14 280 302 272 272
q15 521 479 485 479
q16 465 510 454 454
q17 1164 1571 1404 1404
q18 7784 7432 7500 7432
q19 854 864 984 864
q20 1975 2008 1943 1943
q21 5214 4894 4678 4678
q22 1085 1036 1023 1023
Total cold run time: 52511 ms
Total hot run time: 50714 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2817524245
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2815200701
<details>
<summary>ClickBench: <b>Total hot run time: 29.79 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 942f1dfa72f3d02cc78f0beff602f0381d9fa3b0, data reload: false
query1 0.04 0.04 0.03
query2 0.12 0.10 0.11
query3 0.25 0.19 0.19
query4 1.60 0.19 0.18
query5 0.60 0.58 0.58
query6 1.19 0.71 0.72
query7 0.02 0.02 0.02
query8 0.05 0.04 0.04
query9 0.59 0.53 0.52
query10 0.57 0.58 0.58
query11 0.15 0.10 0.11
query12 0.15 0.11 0.11
query13 0.61 0.60 0.60
query14 1.16 1.19 1.18
query15 0.87 0.85 0.86
query16 0.37 0.39 0.38
query17 1.01 0.98 1.03
query18 0.20 0.20 0.19
query19 1.87 1.83 1.83
query20 0.01 0.02 0.01
query21 15.41 0.92 0.54
query22 0.76 1.17 0.64
query23 14.93 1.34 0.61
query24 6.96 1.06 1.01
query25 0.46 0.26 0.11
query26 0.56 0.17 0.13
query27 0.05 0.05 0.04
query28 9.03 0.87 0.45
query29 12.65 3.97 3.26
query30 0.25 0.09 0.06
query31 2.82 0.60 0.39
query32 3.23 0.54 0.46
query33 3.00 3.07 3.05
query34 15.73 5.16 4.53
query35 4.57 4.58 4.53
query36 0.66 0.50 0.49
query37 0.09 0.06 0.06
query38 0.05 0.04 0.03
query39 0.03 0.02 0.02
query40 0.18 0.14 0.13
query41 0.08 0.03 0.03
query42 0.03 0.03 0.02
query43 0.04 0.03 0.02
Total cold run time: 103 s
Total hot run time: 29.79 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] window funnel [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2811528508
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2815193343
<details>
<summary>TPC-DS: <b>Total hot run time: 185557 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 942f1dfa72f3d02cc78f0beff602f0381d9fa3b0, data reload: false
query1 1014 490 536 490
query2 6554 1795 1781 1781
query3 6737 221 219 219
query4 26590 23255 23383 23255
query5 4368 604 478 478
query6 291 200 184 184
query7 4613 484 280 280
query8 278 234 230 230
query9 8608 2507 2504 2504
query10 469 312 261 261
query11 15332 15065 15157 15065
query12 153 105 105 105
query13 1659 498 400 400
query14 8626 6093 6102 6093
query15 212 184 175 175
query16 7131 634 490 490
query17 981 715 550 550
query18 1960 397 299 299
query19 181 178 147 147
query20 126 115 115 115
query21 211 122 105 105
query22 4267 4385 4380 4380
query23 34025 32799 32799 32799
query24 8494 2361 2380 2361
query25 526 456 384 384
query26 1225 271 150 150
query27 2764 487 323 323
query28 4410 2096 2066 2066
query29 755 553 428 428
query30 279 213 180 180
query31 915 862 776 776
query32 74 71 65 65
query33 555 373 325 325
query34 812 853 505 505
query35 777 811 740 740
query36 941 990 872 872
query37 110 101 78 78
query38 4137 4125 4084 4084
query39 1423 1407 1432 1407
query40 214 121 114 114
query41 62 56 70 56
query42 123 107 106 106
query43 494 474 477 474
query44 1277 791 796 791
query45 180 193 172 172
query46 825 1021 629 629
query47 1771 1799 1734 1734
query48 384 435 297 297
query49 773 505 410 410
query50 638 682 397 397
query51 4111 4151 4093 4093
query52 112 110 100 100
query53 220 246 186 186
query54 557 550 494 494
query55 88 85 82 82
query56 292 289 287 287
query57 1122 1159 1089 1089
query58 263 246 246 246
query59 2595 2672 2555 2555
query60 323 322 293 293
query61 127 122 123 122
query62 824 724 659 659
query63 223 180 180 180
query64 4366 989 663 663
query65 4316 4193 4239 4193
query66 1137 411 307 307
query67 15776 15450 15128 15128
query68 5380 888 512 512
query69 473 301 261 261
query70 1161 1104 1096 1096
query71 396 310 296 296
query72 5841 4767 4790 4767
query73 713 680 346 346
query74 8847 9078 8655 8655
query75 3159 3206 2678 2678
query76 3171 1187 749 749
query77 484 374 323 323
query78 9839 10013 9338 9338
query79 1706 853 555 555
query80 1512 508 441 441
query81 523 261 216 216
query82 401 128 94 94
query83 278 258 233 233
query84 293 102 82 82
query85 801 343 308 308
query86 383 304 288 288
query87 4453 4434 4362 4362
query88 2805 2219 2209 2209
query89 400 332 287 287
query90 1756 210 203 203
query91 152 158 129 129
query92 65 63 68 63
query93 1088 957 588 588
query94 689 417 322 322
query95 377 309 292 292
query96 479 555 276 276
query97 3115 3239 3091 3091
query98 227 214 207 207
query99 1321 1409 1284 1284
Total cold run time: 268064 ms
Total hot run time: 185557 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] window funnel [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2811583195
<details>
<summary>ClickBench: <b>Total hot run time: 30.03 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 69bd89aec16f28942429a32ce48b943d042e85ce, data reload: false
query1 0.04 0.04 0.03
query2 0.12 0.10 0.11
query3 0.26 0.19 0.19
query4 1.59 0.18 0.19
query5 0.61 0.59 0.59
query6 1.22 0.72 0.75
query7 0.02 0.01 0.02
query8 0.04 0.03 0.04
query9 0.60 0.53 0.51
query10 0.57 0.57 0.56
query11 0.16 0.11 0.11
query12 0.15 0.11 0.11
query13 0.62 0.60 0.60
query14 1.21 1.18 1.19
query15 0.87 0.87 0.87
query16 0.38 0.40 0.39
query17 1.03 1.06 1.04
query18 0.21 0.20 0.19
query19 1.94 1.82 1.83
query20 0.01 0.01 0.02
query21 15.41 0.93 0.55
query22 0.76 1.14 0.66
query23 14.98 1.42 0.64
query24 6.83 1.27 1.00
query25 0.52 0.24 0.07
query26 0.52 0.16 0.15
query27 0.05 0.05 0.04
query28 10.12 0.90 0.44
query29 12.52 4.07 3.38
query30 0.24 0.09 0.06
query31 2.82 0.59 0.40
query32 3.24 0.56 0.48
query33 3.08 3.12 3.09
query34 15.90 5.14 4.51
query35 4.54 4.52 4.54
query36 0.67 0.51 0.49
query37 0.09 0.06 0.06
query38 0.06 0.04 0.03
query39 0.04 0.02 0.02
query40 0.16 0.14 0.13
query41 0.08 0.03 0.02
query42 0.03 0.03 0.02
query43 0.04 0.04 0.03
Total cold run time: 104.35 s
Total hot run time: 30.03 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2815388116
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2812401020
<details>
<summary>ClickBench: <b>Total hot run time: 29.43 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 913a686bf5c17026e4848132ed6cd2654797f8af, data reload: false
query1 0.04 0.04 0.03
query2 0.13 0.10 0.11
query3 0.26 0.20 0.19
query4 1.60 0.20 0.19
query5 0.60 0.58 0.59
query6 1.19 0.72 0.72
query7 0.02 0.02 0.02
query8 0.04 0.03 0.04
query9 0.59 0.52 0.52
query10 0.56 0.58 0.56
query11 0.17 0.11 0.11
query12 0.15 0.11 0.11
query13 0.61 0.60 0.59
query14 1.18 1.19 1.19
query15 0.89 0.85 0.83
query16 0.40 0.39 0.36
query17 0.99 1.04 1.01
query18 0.21 0.20 0.20
query19 1.88 1.80 1.76
query20 0.02 0.02 0.01
query21 15.40 0.91 0.55
query22 0.76 1.24 0.66
query23 14.95 1.37 0.61
query24 6.99 1.01 0.95
query25 0.48 0.27 0.05
query26 0.55 0.18 0.13
query27 0.06 0.05 0.04
query28 9.54 0.91 0.44
query29 12.58 3.89 3.27
query30 0.25 0.09 0.07
query31 2.82 0.58 0.38
query32 3.24 0.55 0.46
query33 3.09 3.05 3.07
query34 15.74 5.10 4.42
query35 4.54 4.51 4.46
query36 0.69 0.49 0.47
query37 0.08 0.06 0.06
query38 0.05 0.04 0.03
query39 0.03 0.03 0.02
query40 0.17 0.14 0.13
query41 0.08 0.02 0.02
query42 0.03 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 103.69 s
Total hot run time: 29.43 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2812362412
<details>
<summary>TPC-H: <b>Total hot run time: 34009 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 913a686bf5c17026e4848132ed6cd2654797f8af, data reload: false
------ Round 1 ----------------------------------
q1 26399 5121 5041 5041
q2 2066 276 202 202
q3 10386 1243 700 700
q4 10224 1003 527 527
q5 7545 2298 2426 2298
q6 180 161 134 134
q7 938 762 606 606
q8 9334 1334 1154 1154
q9 6768 5024 5058 5024
q10 6811 2298 1864 1864
q11 481 285 266 266
q12 347 352 219 219
q13 17780 3652 3099 3099
q14 226 221 206 206
q15 534 488 492 488
q16 455 450 410 410
q17 600 855 372 372
q18 7530 7221 7148 7148
q19 1214 931 557 557
q20 334 331 221 221
q21 4451 3374 2495 2495
q22 1039 1011 978 978
Total cold run time: 115642 ms
Total hot run time: 34009 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5099 5114 5127 5114
q2 231 328 231 231
q3 2142 2617 2297 2297
q4 1440 1820 1421 1421
q5 4561 4468 4397 4397
q6 205 172 124 124
q7 1908 1923 1743 1743
q8 2572 2639 2505 2505
q9 7105 7224 7179 7179
q10 3007 3150 2756 2756
q11 576 492 485 485
q12 666 764 659 659
q13 3486 3883 3218 3218
q14 296 304 292 292
q15 517 479 479 479
q16 471 514 464 464
q17 1137 1558 1372 1372
q18 7792 7552 7332 7332
q19 847 840 895 840
q20 1995 2012 1889 1889
q21 5259 4738 4656 4656
q22 1059 988 969 969
Total cold run time: 52371 ms
Total hot run time: 50422 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] window funnel [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2811577679
<details>
<summary>TPC-DS: <b>Total hot run time: 185628 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 69bd89aec16f28942429a32ce48b943d042e85ce, data reload: false
query1 1010 472 480 472
query2 6559 1800 1784 1784
query3 6753 227 216 216
query4 26503 24111 23273 23273
query5 4326 622 446 446
query6 294 208 209 208
query7 4624 486 275 275
query8 298 251 254 251
query9 8631 2545 2563 2545
query10 476 317 292 292
query11 15354 15125 14845 14845
query12 161 116 112 112
query13 1657 517 406 406
query14 8693 6194 6229 6194
query15 211 189 172 172
query16 7131 596 460 460
query17 977 720 575 575
query18 1965 396 310 310
query19 195 183 159 159
query20 120 119 117 117
query21 215 129 105 105
query22 4241 4103 4028 4028
query23 34127 32850 33248 32850
query24 8420 2407 2330 2330
query25 532 444 382 382
query26 1227 278 150 150
query27 2735 498 325 325
query28 4361 2089 2076 2076
query29 772 541 433 433
query30 277 214 188 188
query31 893 848 748 748
query32 76 62 62 62
query33 544 352 301 301
query34 790 862 504 504
query35 812 810 772 772
query36 976 994 910 910
query37 117 107 86 86
query38 4131 4135 4151 4135
query39 1431 1420 1396 1396
query40 207 120 107 107
query41 56 61 52 52
query42 115 101 108 101
query43 494 486 484 484
query44 1351 809 804 804
query45 181 173 177 173
query46 826 1028 613 613
query47 1731 1785 1709 1709
query48 367 411 301 301
query49 797 511 409 409
query50 643 662 397 397
query51 4091 4118 4187 4118
query52 110 114 96 96
query53 221 248 186 186
query54 569 585 521 521
query55 83 76 84 76
query56 315 302 313 302
query57 1116 1139 1052 1052
query58 271 258 258 258
query59 2638 2697 2622 2622
query60 320 338 300 300
query61 143 144 126 126
query62 798 717 637 637
query63 223 191 189 189
query64 4272 1029 714 714
query65 4350 4230 4233 4230
query66 1156 416 308 308
query67 15762 15474 15334 15334
query68 7819 868 507 507
query69 466 293 256 256
query70 1145 1123 1111 1111
query71 464 314 285 285
query72 5628 4712 4780 4712
query73 704 626 343 343
query74 8859 9118 8764 8764
query75 3823 3203 2671 2671
query76 3672 1176 746 746
query77 800 369 284 284
query78 9972 10002 9191 9191
query79 2574 817 574 574
query80 579 508 449 449
query81 499 257 228 228
query82 462 129 103 103
query83 285 262 230 230
query84 364 104 82 82
query85 792 348 313 313
query86 388 302 279 279
query87 4462 4479 4441 4441
query88 3669 2227 2367 2227
query89 381 313 281 281
query90 1844 217 216 216
query91 140 140 112 112
query92 77 63 57 57
query93 2056 940 571 571
query94 665 418 310 310
query95 376 296 284 284
query96 485 567 272 272
query97 3157 3202 3127 3127
query98 223 205 216 205
query99 1442 1431 1285 1285
Total cold run time: 274093 ms
Total hot run time: 185628 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2815477257
<details>
<summary>ClickBench: <b>Total hot run time: 29.49 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b3d8d06c2302d59a89e710c6071e1938540f55e3, data reload: false
query1 0.04 0.04 0.03
query2 0.12 0.10 0.11
query3 0.25 0.19 0.19
query4 1.59 0.20 0.19
query5 0.61 0.59 0.60
query6 1.18 0.72 0.72
query7 0.02 0.02 0.02
query8 0.04 0.03 0.04
query9 0.59 0.52 0.50
query10 0.57 0.57 0.57
query11 0.15 0.11 0.11
query12 0.15 0.12 0.11
query13 0.61 0.61 0.59
query14 1.16 1.18 1.17
query15 0.90 0.85 0.85
query16 0.38 0.40 0.39
query17 1.03 1.02 0.99
query18 0.21 0.20 0.20
query19 1.92 1.80 1.81
query20 0.01 0.01 0.02
query21 15.39 0.88 0.55
query22 0.77 1.22 0.65
query23 14.92 1.39 0.61
query24 8.42 0.66 0.65
query25 0.51 0.15 0.22
query26 0.65 0.16 0.16
query27 0.04 0.05 0.05
query28 8.91 0.86 0.43
query29 12.59 3.99 3.31
query30 0.25 0.10 0.06
query31 2.83 0.61 0.38
query32 3.22 0.55 0.47
query33 2.98 3.07 3.08
query34 15.84 5.11 4.49
query35 4.53 4.50 4.49
query36 0.67 0.49 0.48
query37 0.08 0.06 0.06
query38 0.05 0.04 0.04
query39 0.03 0.03 0.03
query40 0.17 0.14 0.13
query41 0.09 0.02 0.02
query42 0.03 0.02 0.02
query43 0.03 0.03 0.03
Total cold run time: 104.53 s
Total hot run time: 29.49 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2812547107
# BE UT Coverage Report
Increment line coverage `76.47% (78/102)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/913a686bf5c17026e4848132ed6cd2654797f8af_913a686bf5c17026e4848132ed6cd2654797f8af/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/913a686bf5c17026e4848132ed6cd2654797f8af_913a686bf5c17026e4848132ed6cd2654797f8af/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.14% (14424/27141) |
| Line Coverage | 42.01% (124978/297466) |
| Region Coverage | 40.83% (63848/156383) |
| Branch Coverage | 35.47% (32111/90540) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2814514000
<details>
<summary>TPC-DS: <b>Total hot run time: 192685 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 93d3e7f70e7ea67e31d2ecc64e7e975847d4f0b7, data reload: false
query1 1402 1103 1057 1057
query2 6259 1819 1808 1808
query3 11159 4527 4736 4527
query4 25616 23551 23350 23350
query5 4393 632 454 454
query6 283 202 199 199
query7 3994 488 283 283
query8 304 246 246 246
query9 8550 2529 2584 2529
query10 472 338 260 260
query11 15597 15030 14885 14885
query12 170 114 112 112
query13 1560 534 408 408
query14 9547 6106 6220 6106
query15 196 190 170 170
query16 7600 669 485 485
query17 1174 730 586 586
query18 2024 409 316 316
query19 205 184 159 159
query20 126 129 126 126
query21 208 130 111 111
query22 4594 4606 4319 4319
query23 34598 33663 33473 33473
query24 8470 2397 2466 2397
query25 500 461 399 399
query26 1219 269 158 158
query27 2843 503 331 331
query28 4494 2117 2120 2117
query29 709 555 449 449
query30 274 219 188 188
query31 912 876 794 794
query32 73 79 69 69
query33 571 381 315 315
query34 800 876 528 528
query35 826 839 762 762
query36 945 1006 910 910
query37 117 104 79 79
query38 4281 4291 4102 4102
query39 1510 1465 1459 1459
query40 222 126 115 115
query41 59 57 56 56
query42 125 118 112 112
query43 507 504 481 481
query44 1377 824 828 824
query45 194 179 178 178
query46 863 1047 654 654
query47 1862 1843 1786 1786
query48 386 417 314 314
query49 758 496 432 432
query50 661 720 420 420
query51 4250 4424 4289 4289
query52 136 103 101 101
query53 233 261 196 196
query54 575 585 513 513
query55 86 86 83 83
query56 337 308 284 284
query57 1184 1200 1090 1090
query58 256 270 268 268
query59 2715 2783 2685 2685
query60 336 323 308 308
query61 129 125 127 125
query62 786 738 675 675
query63 233 188 190 188
query64 4096 1053 677 677
query65 4490 4438 4336 4336
query66 999 400 312 312
query67 16114 15413 15361 15361
query68 8541 899 516 516
query69 485 303 270 270
query70 1212 1140 1148 1140
query71 461 368 302 302
query72 5736 4738 4867 4738
query73 715 642 352 352
query74 8842 9053 8882 8882
query75 3920 3177 2772 2772
query76 3770 1190 756 756
query77 791 375 271 271
query78 10058 10090 9303 9303
query79 3145 795 542 542
query80 646 493 480 480
query81 478 257 221 221
query82 445 121 95 95
query83 279 247 229 229
query84 291 114 89 89
query85 775 352 316 316
query86 335 312 306 306
query87 4479 4362 4268 4268
query88 3214 2188 2172 2172
query89 441 311 281 281
query90 1978 208 215 208
query91 140 138 110 110
query92 79 60 54 54
query93 2859 947 573 573
query94 686 419 321 321
query95 382 282 285 282
query96 479 572 266 266
query97 3192 3232 3179 3179
query98 227 213 204 204
query99 1428 1428 1298 1298
Total cold run time: 283053 ms
Total hot run time: 192685 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2814518245
<details>
<summary>ClickBench: <b>Total hot run time: 29.5 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 93d3e7f70e7ea67e31d2ecc64e7e975847d4f0b7, data reload: false
query1 0.04 0.04 0.03
query2 0.12 0.10 0.12
query3 0.26 0.20 0.20
query4 1.58 0.19 0.11
query5 0.56 0.55 0.56
query6 1.18 0.70 0.72
query7 0.02 0.02 0.02
query8 0.04 0.03 0.04
query9 0.58 0.53 0.52
query10 0.57 0.58 0.56
query11 0.15 0.11 0.11
query12 0.14 0.11 0.12
query13 0.62 0.61 0.60
query14 1.17 1.17 1.22
query15 0.88 0.84 0.85
query16 0.39 0.38 0.39
query17 1.06 1.04 1.02
query18 0.23 0.21 0.21
query19 1.91 1.76 1.75
query20 0.01 0.01 0.01
query21 15.39 0.92 0.57
query22 0.76 1.04 0.62
query23 15.14 1.40 0.63
query24 6.33 2.61 0.78
query25 0.50 0.14 0.16
query26 0.64 0.17 0.15
query27 0.05 0.05 0.05
query28 9.48 0.92 0.45
query29 12.55 4.00 3.36
query30 0.26 0.09 0.07
query31 2.82 0.59 0.38
query32 3.23 0.56 0.47
query33 3.08 2.99 3.03
query34 15.71 5.22 4.51
query35 4.56 4.52 4.56
query36 0.68 0.50 0.49
query37 0.09 0.06 0.06
query38 0.05 0.04 0.03
query39 0.03 0.02 0.02
query40 0.17 0.13 0.12
query41 0.07 0.03 0.02
query42 0.03 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 103.17 s
Total hot run time: 29.5 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2813116094
<details>
<summary>TPC-H: <b>Total hot run time: 34059 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 913a686bf5c17026e4848132ed6cd2654797f8af, data reload: false
------ Round 1 ----------------------------------
q1 26261 5081 5031 5031
q2 2059 281 193 193
q3 10382 1241 715 715
q4 10238 1021 536 536
q5 7552 2391 2346 2346
q6 181 162 133 133
q7 907 726 625 625
q8 9326 1308 1033 1033
q9 6838 5121 5165 5121
q10 6787 2300 1906 1906
q11 478 282 277 277
q12 348 361 208 208
q13 17755 3638 3144 3144
q14 229 238 205 205
q15 521 482 477 477
q16 447 449 411 411
q17 585 852 367 367
q18 7575 7339 7107 7107
q19 1213 941 549 549
q20 332 337 235 235
q21 4117 3385 2492 2492
q22 1036 996 948 948
Total cold run time: 115167 ms
Total hot run time: 34059 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5124 5092 5084 5084
q2 233 332 223 223
q3 2188 2659 2256 2256
q4 1416 1837 1418 1418
q5 4567 4473 4404 4404
q6 208 176 126 126
q7 1914 1851 1724 1724
q8 2597 2481 2446 2446
q9 7133 7121 7087 7087
q10 2959 3197 2708 2708
q11 571 498 487 487
q12 683 747 604 604
q13 3524 3958 3303 3303
q14 284 288 274 274
q15 526 485 475 475
q16 468 513 455 455
q17 1186 1634 1373 1373
q18 7718 7542 7605 7542
q19 787 782 889 782
q20 1955 2040 1907 1907
q21 5206 4679 4749 4679
q22 1036 1003 989 989
Total cold run time: 52283 ms
Total hot run time: 50346 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2814504725
<details>
<summary>TPC-H: <b>Total hot run time: 34142 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 93d3e7f70e7ea67e31d2ecc64e7e975847d4f0b7, data reload: false
------ Round 1 ----------------------------------
q1 26440 5132 5090 5090
q2 2064 275 187 187
q3 10451 1284 718 718
q4 10239 1019 531 531
q5 7575 2390 2381 2381
q6 180 166 131 131
q7 908 726 599 599
q8 9304 1282 1082 1082
q9 6838 5172 5108 5108
q10 6875 2339 1882 1882
q11 499 286 263 263
q12 346 349 225 225
q13 17769 3746 3128 3128
q14 239 234 215 215
q15 529 482 477 477
q16 444 444 393 393
q17 598 838 380 380
q18 7689 7261 7134 7134
q19 1565 954 555 555
q20 334 322 221 221
q21 4136 3447 2443 2443
q22 1092 1015 999 999
Total cold run time: 116114 ms
Total hot run time: 34142 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5179 5081 5110 5081
q2 235 323 232 232
q3 2171 2651 2282 2282
q4 1435 1824 1469 1469
q5 4456 4454 4386 4386
q6 213 169 127 127
q7 1992 1930 1768 1768
q8 2601 2583 2569 2569
q9 7286 7198 7069 7069
q10 3042 3173 2770 2770
q11 580 518 485 485
q12 716 754 635 635
q13 3495 3940 3333 3333
q14 302 310 281 281
q15 527 478 485 478
q16 466 497 468 468
q17 1168 1539 1412 1412
q18 7810 7604 7440 7440
q19 793 808 831 808
q20 2009 2052 1865 1865
q21 5263 4860 4799 4799
q22 1114 1077 1030 1030
Total cold run time: 52853 ms
Total hot run time: 50787 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2814573839
<details>
<summary>TPC-H: <b>Total hot run time: 34581 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 93d3e7f70e7ea67e31d2ecc64e7e975847d4f0b7, data reload: false
------ Round 1 ----------------------------------
q1 25881 5088 5006 5006
q2 2058 271 183 183
q3 10420 1261 706 706
q4 10260 1014 540 540
q5 8589 2481 2314 2314
q6 270 166 135 135
q7 930 773 612 612
q8 9324 1244 1046 1046
q9 7434 5062 5067 5062
q10 6879 2332 1880 1880
q11 478 301 270 270
q12 337 363 222 222
q13 17780 3680 3056 3056
q14 228 226 203 203
q15 523 493 483 483
q16 454 446 399 399
q17 576 844 375 375
q18 7576 7269 7133 7133
q19 1427 957 550 550
q20 335 327 219 219
q21 4288 3322 3212 3212
q22 1039 1037 975 975
Total cold run time: 117086 ms
Total hot run time: 34581 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5155 5070 5081 5070
q2 234 340 230 230
q3 2095 2626 2270 2270
q4 1451 1950 1513 1513
q5 4540 4397 4343 4343
q6 205 163 129 129
q7 1927 1858 1682 1682
q8 2553 2468 2470 2468
q9 7092 7160 7052 7052
q10 3005 3221 2737 2737
q11 572 511 496 496
q12 660 758 622 622
q13 3516 3879 3240 3240
q14 272 307 281 281
q15 535 485 475 475
q16 469 504 469 469
q17 1141 1579 1384 1384
q18 7683 7396 7318 7318
q19 773 795 975 795
q20 2019 2046 1867 1867
q21 5005 4770 4510 4510
q22 1060 1046 967 967
Total cold run time: 51962 ms
Total hot run time: 49918 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2814682399
# BE UT Coverage Report
Increment line coverage `82.61% (76/92)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/93d3e7f70e7ea67e31d2ecc64e7e975847d4f0b7_93d3e7f70e7ea67e31d2ecc64e7e975847d4f0b7/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/93d3e7f70e7ea67e31d2ecc64e7e975847d4f0b7_93d3e7f70e7ea67e31d2ecc64e7e975847d4f0b7/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.16% (14426/27138) |
| Line Coverage | 42.02% (125009/297475) |
| Region Coverage | 40.84% (63864/156385) |
| Branch Coverage | 35.47% (32119/90546) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2812389169
<details>
<summary>TPC-DS: <b>Total hot run time: 186056 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 913a686bf5c17026e4848132ed6cd2654797f8af, data reload: false
query1 1007 480 507 480
query2 6558 1799 1750 1750
query3 6735 213 215 213
query4 26381 23955 23390 23390
query5 5442 628 440 440
query6 310 206 194 194
query7 4639 496 277 277
query8 303 242 249 242
query9 8670 2526 2550 2526
query10 494 315 266 266
query11 15264 15541 14829 14829
query12 159 109 104 104
query13 1638 500 412 412
query14 9847 6144 6209 6144
query15 206 185 168 168
query16 7634 643 486 486
query17 1158 710 571 571
query18 2001 391 301 301
query19 187 185 168 168
query20 121 116 118 116
query21 206 118 102 102
query22 4110 4166 4050 4050
query23 33810 32819 32860 32819
query24 8417 2425 2333 2333
query25 514 452 385 385
query26 1236 273 151 151
query27 2751 493 328 328
query28 4387 2082 2080 2080
query29 723 559 443 443
query30 277 216 192 192
query31 922 873 799 799
query32 73 64 61 61
query33 557 370 301 301
query34 774 848 501 501
query35 811 791 736 736
query36 950 968 887 887
query37 111 97 71 71
query38 4160 4198 4163 4163
query39 1446 1394 1400 1394
query40 214 131 107 107
query41 55 52 51 51
query42 116 114 100 100
query43 498 505 476 476
query44 1277 786 791 786
query45 184 171 168 168
query46 826 1010 616 616
query47 1751 1772 1725 1725
query48 398 404 300 300
query49 783 495 414 414
query50 640 672 398 398
query51 4205 4173 4107 4107
query52 108 108 94 94
query53 242 260 182 182
query54 567 561 495 495
query55 82 78 90 78
query56 314 290 306 290
query57 1178 1153 1075 1075
query58 274 265 265 265
query59 2605 2626 2541 2541
query60 328 336 324 324
query61 156 146 145 145
query62 791 720 690 690
query63 235 193 193 193
query64 4372 1098 791 791
query65 4365 4228 4273 4228
query66 1022 454 325 325
query67 15751 15441 15361 15361
query68 8053 883 511 511
query69 484 292 268 268
query70 1233 1133 1103 1103
query71 486 314 284 284
query72 5532 4759 4772 4759
query73 712 605 344 344
query74 9097 9094 9042 9042
query75 3958 3210 2696 2696
query76 3733 1187 774 774
query77 784 392 291 291
query78 10041 9997 9316 9316
query79 2660 814 573 573
query80 628 515 444 444
query81 506 258 225 225
query82 486 124 93 93
query83 281 240 234 234
query84 294 104 83 83
query85 783 358 319 319
query86 387 303 288 288
query87 4503 4423 4278 4278
query88 3415 2233 2235 2233
query89 384 315 295 295
query90 1945 219 217 217
query91 143 141 114 114
query92 81 65 60 60
query93 1851 948 579 579
query94 651 411 304 304
query95 368 294 277 277
query96 538 569 273 273
query97 3247 3240 3088 3088
query98 235 209 212 209
query99 1458 1369 1284 1284
Total cold run time: 277283 ms
Total hot run time: 186056 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2813163417
<details>
<summary>ClickBench: <b>Total hot run time: 29.11 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 913a686bf5c17026e4848132ed6cd2654797f8af, data reload: false
query1 0.04 0.04 0.03
query2 0.13 0.10 0.12
query3 0.25 0.20 0.19
query4 1.59 0.19 0.11
query5 0.56 0.57 0.57
query6 1.19 0.71 0.72
query7 0.02 0.02 0.01
query8 0.04 0.03 0.03
query9 0.58 0.53 0.52
query10 0.58 0.58 0.56
query11 0.16 0.11 0.12
query12 0.14 0.11 0.11
query13 0.61 0.59 0.60
query14 1.20 1.18 1.22
query15 0.86 0.84 0.83
query16 0.39 0.38 0.38
query17 1.02 1.00 0.99
query18 0.21 0.20 0.20
query19 1.89 1.77 1.78
query20 0.01 0.01 0.02
query21 15.41 0.91 0.55
query22 0.75 1.26 0.63
query23 14.90 1.37 0.62
query24 7.19 1.57 0.60
query25 0.46 0.15 0.22
query26 0.74 0.16 0.13
query27 0.05 0.05 0.05
query28 9.07 0.86 0.43
query29 12.61 3.99 3.32
query30 0.25 0.09 0.07
query31 2.84 0.60 0.39
query32 3.22 0.55 0.47
query33 3.04 3.01 3.02
query34 15.74 5.13 4.44
query35 4.51 4.53 4.46
query36 0.66 0.51 0.48
query37 0.08 0.06 0.06
query38 0.05 0.05 0.04
query39 0.03 0.03 0.02
query40 0.18 0.13 0.14
query41 0.09 0.03 0.02
query42 0.04 0.02 0.02
query43 0.03 0.03 0.02
Total cold run time: 103.41 s
Total hot run time: 29.11 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2813043377
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2814407316
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2814539258
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2814585325
<details>
<summary>TPC-DS: <b>Total hot run time: 185171 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 93d3e7f70e7ea67e31d2ecc64e7e975847d4f0b7, data reload: false
query1 1011 479 491 479
query2 6568 1811 1817 1811
query3 6741 219 217 217
query4 26279 23741 23273 23273
query5 4327 603 475 475
query6 317 195 188 188
query7 4621 482 274 274
query8 279 235 228 228
query9 8614 2520 2518 2518
query10 483 346 262 262
query11 15240 15057 14882 14882
query12 171 109 103 103
query13 1664 516 411 411
query14 8877 6179 6102 6102
query15 200 193 176 176
query16 7340 614 474 474
query17 1210 724 583 583
query18 1982 411 314 314
query19 186 195 160 160
query20 118 114 117 114
query21 211 134 110 110
query22 4022 4266 4039 4039
query23 33815 32725 32888 32725
query24 8446 2349 2429 2349
query25 538 447 407 407
query26 1232 259 144 144
query27 2771 486 334 334
query28 4324 2092 2058 2058
query29 749 554 439 439
query30 284 210 187 187
query31 902 823 763 763
query32 71 71 64 64
query33 597 361 303 303
query34 784 872 505 505
query35 805 825 754 754
query36 951 979 896 896
query37 114 108 80 80
query38 4142 4142 4103 4103
query39 1603 1389 1372 1372
query40 222 119 112 112
query41 61 66 53 53
query42 118 105 105 105
query43 484 508 467 467
query44 1320 799 800 799
query45 173 174 166 166
query46 835 1015 612 612
query47 1717 1775 1721 1721
query48 368 399 289 289
query49 766 485 422 422
query50 641 662 404 404
query51 4086 4143 4076 4076
query52 107 108 95 95
query53 229 251 179 179
query54 575 557 520 520
query55 80 81 82 81
query56 296 294 289 289
query57 1141 1129 1062 1062
query58 279 259 265 259
query59 2631 2672 2585 2585
query60 321 311 302 302
query61 127 125 128 125
query62 785 734 667 667
query63 220 189 198 189
query64 4382 986 648 648
query65 4326 4189 4211 4189
query66 1159 406 346 346
query67 15554 15566 15195 15195
query68 7981 872 504 504
query69 475 293 255 255
query70 1184 1094 1115 1094
query71 454 325 332 325
query72 5364 4698 4712 4698
query73 727 619 341 341
query74 8827 8953 8993 8953
query75 3887 3186 2719 2719
query76 3730 1177 747 747
query77 783 367 287 287
query78 10023 10129 9212 9212
query79 2313 807 562 562
query80 627 505 453 453
query81 485 256 219 219
query82 454 124 100 100
query83 248 250 222 222
query84 258 107 86 86
query85 780 344 385 344
query86 386 297 296 296
query87 4341 4400 4306 4306
query88 3530 2220 2205 2205
query89 385 312 287 287
query90 1847 211 214 211
query91 146 139 110 110
query92 78 56 55 55
query93 1729 956 582 582
query94 670 412 264 264
query95 368 293 349 293
query96 474 559 270 270
query97 3150 3246 3079 3079
query98 234 208 210 208
query99 1655 1393 1251 1251
Total cold run time: 273185 ms
Total hot run time: 185171 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2815291313
# BE UT Coverage Report
Increment line coverage `82.61% (76/92)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/942f1dfa72f3d02cc78f0beff602f0381d9fa3b0_942f1dfa72f3d02cc78f0beff602f0381d9fa3b0/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/942f1dfa72f3d02cc78f0beff602f0381d9fa3b0_942f1dfa72f3d02cc78f0beff602f0381d9fa3b0/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.16% (14430/27143) |
| Line Coverage | 42.02% (125000/297475) |
| Region Coverage | 40.84% (63859/156378) |
| Branch Coverage | 35.47% (32116/90538) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2815468184
<details>
<summary>TPC-DS: <b>Total hot run time: 192108 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b3d8d06c2302d59a89e710c6071e1938540f55e3, data reload: false
query1 1443 1079 1080 1079
query2 6053 1772 1829 1772
query3 11002 4612 4510 4510
query4 26036 23838 23174 23174
query5 5173 625 460 460
query6 315 196 190 190
query7 3986 481 280 280
query8 290 245 234 234
query9 8514 2511 2527 2511
query10 498 323 252 252
query11 15441 15009 14748 14748
query12 154 112 106 106
query13 1549 513 392 392
query14 8925 6098 6113 6098
query15 211 179 160 160
query16 7431 634 471 471
query17 1132 758 627 627
query18 1992 407 305 305
query19 192 175 155 155
query20 127 124 122 122
query21 209 122 117 117
query22 4511 4453 4314 4314
query23 34275 33745 33477 33477
query24 8459 2400 2415 2400
query25 513 458 405 405
query26 1233 263 146 146
query27 3014 501 331 331
query28 4557 2150 2135 2135
query29 674 577 445 445
query30 277 229 192 192
query31 912 906 768 768
query32 80 66 63 63
query33 544 365 303 303
query34 821 880 510 510
query35 802 843 768 768
query36 976 1020 918 918
query37 116 103 78 78
query38 4196 4298 4208 4208
query39 1521 1447 1423 1423
query40 213 121 107 107
query41 56 50 58 50
query42 131 116 111 111
query43 517 511 467 467
query44 1295 816 821 816
query45 180 173 174 173
query46 850 1044 649 649
query47 1874 1873 1783 1783
query48 379 432 305 305
query49 750 514 446 446
query50 672 734 406 406
query51 4350 4252 4254 4252
query52 108 110 98 98
query53 229 267 189 189
query54 586 578 510 510
query55 84 83 96 83
query56 305 317 303 303
query57 1213 1200 1123 1123
query58 269 272 265 265
query59 2565 2755 2610 2610
query60 347 345 322 322
query61 155 163 147 147
query62 782 740 662 662
query63 231 202 188 188
query64 4160 1139 790 790
query65 4473 4408 4354 4354
query66 1329 405 309 309
query67 15685 15618 15216 15216
query68 8433 899 517 517
query69 506 305 293 293
query70 1232 1107 1148 1107
query71 455 333 298 298
query72 5763 4837 4832 4832
query73 720 636 349 349
query74 9051 9123 8731 8731
query75 3869 3204 2691 2691
query76 3800 1182 748 748
query77 807 384 282 282
query78 9969 10121 9450 9450
query79 3746 836 547 547
query80 649 512 436 436
query81 482 270 217 217
query82 504 131 98 98
query83 281 254 228 228
query84 291 100 91 91
query85 765 369 313 313
query86 342 296 278 278
query87 4484 4490 4232 4232
query88 3226 2208 2205 2205
query89 441 316 303 303
query90 2056 222 214 214
query91 139 146 119 119
query92 77 59 69 59
query93 2194 955 588 588
query94 686 391 298 298
query95 379 287 336 287
query96 479 582 268 268
query97 3155 3276 3176 3176
query98 226 216 212 212
query99 1493 1379 1260 1260
Total cold run time: 282642 ms
Total hot run time: 192108 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2815551717
# BE UT Coverage Report
Increment line coverage `82.22% (74/90)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/b3d8d06c2302d59a89e710c6071e1938540f55e3_b3d8d06c2302d59a89e710c6071e1938540f55e3/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/b3d8d06c2302d59a89e710c6071e1938540f55e3_b3d8d06c2302d59a89e710c6071e1938540f55e3/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.16% (14430/27143) |
| Line Coverage | 42.02% (125002/297470) |
| Region Coverage | 40.84% (63869/156379) |
| Branch Coverage | 35.47% (32114/90536) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](function) Optimize the performance of the window funnel function [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #50109:
URL: https://github.com/apache/doris/pull/50109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] window funnel [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50109:
URL: https://github.com/apache/doris/pull/50109#issuecomment-2809584611
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org