You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alexandr Antonenko <hi...@gmail.com> on 2014/12/09 18:41:10 UTC
Review Request 28856: View: CapScheduler enhancements, cleanup
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28856/
-----------------------------------------------------------
Review request for Ambari and Andriy Babiichuk.
Bugs: AMBARI-8404
https://issues.apache.org/jira/browse/AMBARI-8404
Repository: ambari
Description
-------
Enhancements that are needed:
- if not operator, disable save/refresh/restart control in the UI
- if not operator, disable add queue in the UI
- if not operator, remove the "show edit" links in the UI
- if not operator, disable delete queue in the UI
- Also, Delete Queue does not work in Firefox (control does not render properly after clicking)
- basically, the view is just for viewing the queues at that point when the user isOperator == false
Diffs
-----
contrib/views/capacity-scheduler/pom.xml 6245a3f
contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java 556491e
contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js ca2cdee
contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/fonts/FontAwesome.otf PRE-CREATION
contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.eot PRE-CREATION
contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.ttf PRE-CREATION
contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.woff PRE-CREATION
contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js eb743c4
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/clickElsewhere.js PRE-CREATION
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDelete.js 8aaebf5
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/dropdownConfirmation.js PRE-CREATION
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/pathInput.js ccdd5f1
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/totalCapacity.js aad6682
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/userGroupInput.js ff0300d
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js 91e3903
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queues.js cdbf41b
contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js ebea5ff
contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 4b951d3
contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js ceb4f86
contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less 2f13d09
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/pathInput.hbs ec4ec4c
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/totalCapacity.hbs f6f3c64
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs 9a99b18
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queues.hbs 9ad20cb
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/schedulerPanel.hbs 0a52ffa
contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queues.js PRE-CREATION
contrib/views/capacity-scheduler/src/main/resources/ui/config.coffee 7bd9fa5
Diff: https://reviews.apache.org/r/28856/diff/
Testing
-------
Thanks,
Alexandr Antonenko
Re: Review Request 28856: View: CapScheduler enhancements, cleanup
Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28856/#review64396
-----------------------------------------------------------
Ship it!
Ship It!
- Andriy Babiichuk
On Дек. 9, 2014, 5:41 п.п., Alexandr Antonenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28856/
> -----------------------------------------------------------
>
> (Updated Дек. 9, 2014, 5:41 п.п.)
>
>
> Review request for Ambari and Andriy Babiichuk.
>
>
> Bugs: AMBARI-8404
> https://issues.apache.org/jira/browse/AMBARI-8404
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enhancements that are needed:
>
> - if not operator, disable save/refresh/restart control in the UI
> - if not operator, disable add queue in the UI
> - if not operator, remove the "show edit" links in the UI
> - if not operator, disable delete queue in the UI
> - Also, Delete Queue does not work in Firefox (control does not render properly after clicking)
> - basically, the view is just for viewing the queues at that point when the user isOperator == false
>
>
> Diffs
> -----
>
> contrib/views/capacity-scheduler/pom.xml 6245a3f
> contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java 556491e
> contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js ca2cdee
> contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/fonts/FontAwesome.otf PRE-CREATION
> contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.eot PRE-CREATION
> contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.ttf PRE-CREATION
> contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.woff PRE-CREATION
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js eb743c4
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/clickElsewhere.js PRE-CREATION
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDelete.js 8aaebf5
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/dropdownConfirmation.js PRE-CREATION
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/pathInput.js ccdd5f1
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/totalCapacity.js aad6682
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/userGroupInput.js ff0300d
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js 91e3903
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queues.js cdbf41b
> contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js ebea5ff
> contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 4b951d3
> contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js ceb4f86
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less 2f13d09
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/pathInput.hbs ec4ec4c
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/totalCapacity.hbs f6f3c64
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs 9a99b18
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queues.hbs 9ad20cb
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/schedulerPanel.hbs 0a52ffa
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queues.js PRE-CREATION
> contrib/views/capacity-scheduler/src/main/resources/ui/config.coffee 7bd9fa5
>
> Diff: https://reviews.apache.org/r/28856/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexandr Antonenko
>
>