[jira] [Commented] (FLINK-10329) Fail with exception if job cannot be removed by ZooKeeperSubmittedJobGraphStore#removeJobGraph

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612387#comment-16612387 ] 

ASF GitHub Bot commented on FLINK-10329:
----------------------------------------

tillrohrmann opened a new pull request #6686: [FLINK-10329] [FLINK-10328] Fail ZooKeeperSubmittedJobGraphStore#removeJobGraph if job cannot be removed & Release all locks when stopping the ZooKeeperSubmittedJobGraphStore
URL: https://github.com/apache/flink/pull/6686
 
 
   ## What is the purpose of the change
   
   Fail properly with an exception if we cannot remove the JobGraph in ZooKeeperSubmittedJobGraphStore#
   removeJobGraph. This is necessary in order to notify callers about the unsuccessful attempt.
   
   When stopping the ZooKeeperSubmittedJobGraphStore, it will release all currently held
   locks such that other instances can remove entries from the store. This is necessary
   if we don't immediately close the used CuratorFramework/ZooKeeper client.
   
   This PR is based on #6678.
   
   ## Verifying this change
   
   - Added `ZooKeeperSubmittedJobGraphStoreTest#testJobGraphRemovalFailureAndLockRelease`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fail with exception if job cannot be removed by ZooKeeperSubmittedJobGraphStore#removeJobGraph
> ----------------------------------------------------------------------------------------------
>
>                 Key: FLINK-10329
>                 URL: https://issues.apache.org/jira/browse/FLINK-10329
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Coordination
>    Affects Versions: 1.5.3, 1.6.0, 1.7.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.1, 1.7.0, 1.5.4
>
>
> Callers of {{ZooKeeperSubmittedJobGraph#removeJobGraph}} expect that we fail with an exception if the {{JobGraph}} cannot be removed. This is not the case since we call internally {{ZooKeeperStateHandleStore#releaseAndTryRemove}}. If this method returns {{false}}, then we need to fail with an exception.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)