You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2015/10/27 01:25:25 UTC
[GitHub] incubator-brooklyn pull request: License
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/990
License
minor edits to license metadata
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn license
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/990.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #990
----
commit 3e85eb4609825c5be88fd13363db27b83f92cb04
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-10-26T21:35:24Z
note that the version of URI.js is 0.1
commit eba414b8a5a149ced7ebb2f465b066ab063940e6
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-10-26T21:50:13Z
note where different JS versions are used in cli build and docs as compared with js gui
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License
Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/990#discussion_r43244714
--- Diff: usage/cli/src/main/license/source-inclusions.yaml ---
@@ -20,5 +20,5 @@
# extras file for org.heneveld.license-audit-maven-plugin
# listing projects from which *source* files are included
-- id: underscore.js
+- id: underscore.js:1.7.0
--- End diff --
Just a query on the plugin - I can see this ties up with the entry in the overrides.yaml, its not clear how/where this file gets picked up from the [license-audit-maven-plugin](https://github.com/ahgittin/license-audit-maven-plugin) readme?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/990#discussion_r43245418
--- Diff: usage/cli/src/main/license/source-inclusions.yaml ---
@@ -20,5 +20,5 @@
# extras file for org.heneveld.license-audit-maven-plugin
# listing projects from which *source* files are included
-- id: underscore.js
+- id: underscore.js:1.7.0
--- End diff --
our `make-*-license*` scripts combine the relevant `source-inclusions.yaml` files in order to construct the `extrasFile` passed to the plugin. i've updated `README` to explain this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License
Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/990#issuecomment-151825477
Just that last comment on the underscore copyright and it looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License
Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/990#discussion_r43246328
--- Diff: usage/dist/licensing/overrides.yaml ---
@@ -176,6 +200,15 @@
notice: Copyright (c) Jeremy Ashkenas, DocumentCloud Inc (2009-2013)
license: MIT
+# used in CLI (and in docs)
+- id: underscore.js:1.7.0
+ version: 1.7.0
+ files: underscore*.{js,map}
+ url: http://underscorejs.org
+ organization: { name: "DocumentCloud Inc", url: "http://www.documentcloud.org/" }
+ notice: Copyright (c) Jeremy Ashkenas, DocumentCloud Inc (2009-2014)
--- End diff --
(c) 2009-2014 Jeremy Ashkenas, DocumentCloud and Investigative Reporters & Editors
See [underscore-min.js](https://github.com/apache/incubator-brooklyn/blob/master/usage/cli/src/main/resources/brooklyn/item-lister/statics/style/js/underscore-min.js)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/990
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License
Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/990#discussion_r43246208
--- Diff: LICENSE ---
@@ -352,6 +352,14 @@ This project includes the software: underscore.js
Used under the following license: The MIT License (http://opensource.org/licenses/MIT)
Copyright (c) Jeremy Ashkenas, DocumentCloud Inc (2009-2013)
+This project includes the software: underscore.js:1.7.0
+ Available at: http://underscorejs.org
+ Developed by: DocumentCloud Inc (http://www.documentcloud.org/)
+ Inclusive of: underscore*.{js,map}
+ Version used: 1.7.0
+ Used under the following license: The MIT License (http://opensource.org/licenses/MIT)
+ Copyright (c) Jeremy Ashkenas, DocumentCloud Inc (2009-2014)
--- End diff --
(c) 2009-2014 Jeremy Ashkenas, DocumentCloud and Investigative Reporters & Editors
See [underscore-min.js](https://github.com/apache/incubator-brooklyn/blob/master/usage/cli/src/main/resources/brooklyn/item-lister/statics/style/js/underscore-min.js)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/990#issuecomment-151552346
failure is unrelated (karaf issue people are working on).
@johnmccabe does this look okay to you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/990#issuecomment-151818734
@johnmccabe great comments -- many eyes is great for making this rock solid! i think i've addressed them, and regenerated licenses. ready to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License
Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/990#discussion_r43240290
--- Diff: usage/jsgui/src/main/webapp/assets/js/libs/URI.js ---
@@ -1,5 +1,5 @@
/*
- * Taken from http://code.google.com/p/js-uri/ r29. BSD license.
+ * Taken from http://code.google.com/p/js-uri/ v0.1. BSD license.
--- End diff --
Looks good, triple checked the version in the 0.1 release is identical
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---