[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #6670: [INLONG-6584][Sort] Add read phase metric and table level metric for MYSQL

[GitBox <gi...@apache.org>]

yunqingmoswu commented on code in PR #6670:
URL: https://github.com/apache/inlong/pull/6670#discussion_r1035465961


##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/enums/ReadPhase.java:
##########
@@ -0,0 +1,85 @@
+/*
+ *   Licensed to the Apache Software Foundation (ASF) under one
+ *   or more contributor license agreements.  See the NOTICE file
+ *   distributed with this work for additional information
+ *   regarding copyright ownership.  The ASF licenses this file
+ *   to you under the Apache License, Version 2.0 (the
+ *   "License"); you may not use this file except in compliance
+ *   with the License.  You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing, software
+ *   distributed under the License is distributed on an "AS IS" BASIS,
+ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *   See the License for the specific language governing permissions and
+ *   limitations under the License.
+ */
+
+package org.apache.inlong.sort.base.enums;
+
+import java.util.stream.Stream;
+
+/**
+ * A enum class for metrics read phase
+ */
+public enum ReadPhase {
+
+    /**
+     * This indicator represents the prepare phase during the read phase
+     */
+    PREPARE_PHASE("prepare_phase", 0L),
+
+    /**
+     * This indicator represents the snapshot phase during the read phase
+     */
+    SNAPSHOT_PHASE("snapshot_phase", 1L),
+    /**
+     * This indicator represents the incremental phase during the read phase
+     */
+    INCREASE_PHASE("incremental_phase", 2L);
+
+    private String phase;
+    private Long value;

Review Comment:
   Is 'int' enough? and is a numeric code necessary？



##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/metric/phase/ReadPhaseMetricData.java:
##########
@@ -0,0 +1,105 @@
+/*
+ *   Licensed to the Apache Software Foundation (ASF) under one
+ *   or more contributor license agreements.  See the NOTICE file
+ *   distributed with this work for additional information
+ *   regarding copyright ownership.  The ASF licenses this file
+ *   to you under the Apache License, Version 2.0 (the
+ *   "License"); you may not use this file except in compliance
+ *   with the License.  You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing, software
+ *   distributed under the License is distributed on an "AS IS" BASIS,
+ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *   See the License for the specific language governing permissions and
+ *   limitations under the License.
+ */
+
+package org.apache.inlong.sort.base.metric.phase;
+
+import static org.apache.inlong.sort.base.Constants.READ_PHASE_TIMESTAMP;
+
+import java.util.Map;
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.inlong.sort.base.metric.MetricData;
+import org.apache.inlong.sort.base.metric.MetricOption;
+import org.apache.inlong.sort.base.metric.ThreadSafeCounter;
+
+/**
+ * A collection class for handling read phase metric data
+ */
+public class ReadPhaseMetricData implements MetricData {

Review Comment:
   I think that 'ReadPhaseMetricData' is not the commonality of all connectors, and it is not very suitable to put it in the base



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org